From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8630 invoked by alias); 30 Jun 2018 20:25:18 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 8620 invoked by uid 89); 30 Jun 2018 20:25:17 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy=avoids, H*c:HHHH X-HELO: relay1.mentorg.com Date: Sat, 30 Jun 2018 20:25:00 -0000 From: Joseph Myers To: Wilco Dijkstra CC: "libc-alpha@sourceware.org" , nd Subject: Re: [PATCH1/2] Improve performance of sincosf In-Reply-To: Message-ID: References: , , User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="-1152306461-2120469647-1530390310=:4334" X-SW-Source: 2018-06/txt/msg01034.txt.bz2 ---1152306461-2120469647-1530390310=:4334 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT Content-length: 612 On Sat, 30 Jun 2018, Wilco Dijkstra wrote: > Joseph Myers wrote: > > > You then need to add a dummy s_sincosf_data.c for architectures with their > > own sincosf implementation, to avoid wasting space in libm.so with unused > > data from s_sincosf_data.c.  That looks like ia64, m68k, x86_64. > > It's about 256 bytes so it's not a huge waste, I'll do it as a separate > enhancement when I get back from holiday. I think the patch that adds a file only relevant to some targets should be the same patch that also avoids it building any code for other targets. -- Joseph S. Myers joseph@codesourcery.com ---1152306461-2120469647-1530390310=:4334--