From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 73005 invoked by alias); 18 Jul 2018 20:15:42 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 72642 invoked by uid 89); 18 Jul 2018 20:15:23 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy=Hx-languages-length:780, H*Ad:U*hch, HCC:D*uk, family X-HELO: relay1.mentorg.com Date: Wed, 18 Jul 2018 20:15:00 -0000 From: Joseph Myers To: Arnd Bergmann CC: Christoph Hellwig , Thomas Gleixner , y2038 Mailman List , Linux API , linux-arch , GNU C Library , Albert ARIBAUD , Networking , Al Viro , Peter Zijlstra , Darren Hart , "Eric W . Biederman" , Dominik Brodowski Subject: Re: [PATCH v2 02/17] y2038: Remove newstat family from default syscall set In-Reply-To: Message-ID: References: <20180716161103.16239-1-arnd@arndb.de> <20180716161103.16239-3-arnd@arndb.de> <20180717125039.GB25416@infradead.org> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-SW-Source: 2018-07/txt/msg00577.txt.bz2 On Tue, 17 Jul 2018, Arnd Bergmann wrote: > That would definitely help. See below for the stat implementation > I did in my musl libc prototype based on statx(). It passes the > LTP syscall tests, but that doesn't mean all the corner cases > are correct. Well, you definitely need explicit timestamp conversions on the result of statx to be usable in struct stat when userspace "long" is 64-bit, for BE because otherwise the integer nanoseconds will be in the wrong place for struct timespec, and for LE if the "__reserved is held in case we need a yet finer resolution." might start being returned as nonzero (for integer attoseconds, I suppose) in future. -- Joseph S. Myers joseph@codesourcery.com