* [PATCH] tst-tzset: raise timeout to 10 seconds
@ 2018-07-30 15:28 Alexey Brodkin
2018-07-30 15:58 ` Joseph Myers
0 siblings, 1 reply; 5+ messages in thread
From: Alexey Brodkin @ 2018-07-30 15:28 UTC (permalink / raw)
To: libc-alpha; +Cc: linux-snps-arc, Alexey Brodkin
On ARC HSDK board even though it operates @ 1GHz this test runs
~7 seconds which gives us failures all the time.
That's what happens now:
| # time .../build/timezone/tst-tzset
| Timed out: killed the child process
| Command exited with non-zero status 1
| real 0m 5.11s
| user 0m 3.59s
| sys 0m 1.45s
And that's what happens with longer time-out:
| # time .../build/timezone/tst-tzset
| real 0m 6.95s
| user 0m 4.97s
| sys 0m 1.99s
|
| # echo $?
| 0
---
timezone/tst-tzset.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/timezone/tst-tzset.c b/timezone/tst-tzset.c
index 27f986b56dab..534f7acdf75f 100644
--- a/timezone/tst-tzset.c
+++ b/timezone/tst-tzset.c
@@ -25,7 +25,7 @@
#include <time.h>
#include <unistd.h>
-#define TIMEOUT 5
+#define TIMEOUT 10
static int do_test (void);
#define TEST_FUNCTION do_test ()
#include "../test-skeleton.c"
--
2.17.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] tst-tzset: raise timeout to 10 seconds
2018-07-30 15:28 [PATCH] tst-tzset: raise timeout to 10 seconds Alexey Brodkin
@ 2018-07-30 15:58 ` Joseph Myers
2018-07-30 16:07 ` Andreas Schwab
0 siblings, 1 reply; 5+ messages in thread
From: Joseph Myers @ 2018-07-30 15:58 UTC (permalink / raw)
To: Alexey Brodkin; +Cc: libc-alpha, linux-snps-arc
On Mon, 30 Jul 2018, Alexey Brodkin wrote:
> diff --git a/timezone/tst-tzset.c b/timezone/tst-tzset.c
> index 27f986b56dab..534f7acdf75f 100644
> --- a/timezone/tst-tzset.c
> +++ b/timezone/tst-tzset.c
> @@ -25,7 +25,7 @@
> #include <time.h>
> #include <unistd.h>
>
> -#define TIMEOUT 5
> +#define TIMEOUT 10
The timeout was set to 5 in commit
112f28e88c4ea5afbd6050e71416a23db11e4adc to increase it from a default 2
seconds. That was before the default timeout was changed to 20 seconds in
commit a28605b22946c708f0a5c4f06307e1a17650ced8. In such cases I think we
should remove the timeout setting - explicit timeouts less than the
default are only appropriate where there is a strong reason to want to
*decrease* the default timeout.
--
Joseph S. Myers
joseph@codesourcery.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] tst-tzset: raise timeout to 10 seconds
2018-07-30 15:58 ` Joseph Myers
@ 2018-07-30 16:07 ` Andreas Schwab
2018-07-30 16:51 ` Florian Weimer
0 siblings, 1 reply; 5+ messages in thread
From: Andreas Schwab @ 2018-07-30 16:07 UTC (permalink / raw)
To: Joseph Myers; +Cc: Alexey Brodkin, libc-alpha, linux-snps-arc
On Jul 30 2018, Joseph Myers <joseph@codesourcery.com> wrote:
> On Mon, 30 Jul 2018, Alexey Brodkin wrote:
>
>> diff --git a/timezone/tst-tzset.c b/timezone/tst-tzset.c
>> index 27f986b56dab..534f7acdf75f 100644
>> --- a/timezone/tst-tzset.c
>> +++ b/timezone/tst-tzset.c
>> @@ -25,7 +25,7 @@
>> #include <time.h>
>> #include <unistd.h>
>>
>> -#define TIMEOUT 5
>> +#define TIMEOUT 10
>
> The timeout was set to 5 in commit
> 112f28e88c4ea5afbd6050e71416a23db11e4adc to increase it from a default 2
> seconds. That was before the default timeout was changed to 20 seconds in
> commit a28605b22946c708f0a5c4f06307e1a17650ced8. In such cases I think we
> should remove the timeout setting - explicit timeouts less than the
> default are only appropriate where there is a strong reason to want to
> *decrease* the default timeout.
There are a lot of tests that set TIMEOUT to less than 20.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] tst-tzset: raise timeout to 10 seconds
2018-07-30 16:07 ` Andreas Schwab
@ 2018-07-30 16:51 ` Florian Weimer
2018-07-30 17:12 ` Joseph Myers
0 siblings, 1 reply; 5+ messages in thread
From: Florian Weimer @ 2018-07-30 16:51 UTC (permalink / raw)
To: Andreas Schwab, Joseph Myers; +Cc: Alexey Brodkin, libc-alpha, linux-snps-arc
On 07/30/2018 06:07 PM, Andreas Schwab wrote:
> On Jul 30 2018, Joseph Myers <joseph@codesourcery.com> wrote:
>
>> On Mon, 30 Jul 2018, Alexey Brodkin wrote:
>>
>>> diff --git a/timezone/tst-tzset.c b/timezone/tst-tzset.c
>>> index 27f986b56dab..534f7acdf75f 100644
>>> --- a/timezone/tst-tzset.c
>>> +++ b/timezone/tst-tzset.c
>>> @@ -25,7 +25,7 @@
>>> #include <time.h>
>>> #include <unistd.h>
>>>
>>> -#define TIMEOUT 5
>>> +#define TIMEOUT 10
>>
>> The timeout was set to 5 in commit
>> 112f28e88c4ea5afbd6050e71416a23db11e4adc to increase it from a default 2
>> seconds. That was before the default timeout was changed to 20 seconds in
>> commit a28605b22946c708f0a5c4f06307e1a17650ced8. In such cases I think we
>> should remove the timeout setting - explicit timeouts less than the
>> default are only appropriate where there is a strong reason to want to
>> *decrease* the default timeout.
>
> There are a lot of tests that set TIMEOUT to less than 20.
We should fix all of them.
Thanks,
Florian
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] tst-tzset: raise timeout to 10 seconds
2018-07-30 16:51 ` Florian Weimer
@ 2018-07-30 17:12 ` Joseph Myers
0 siblings, 0 replies; 5+ messages in thread
From: Joseph Myers @ 2018-07-30 17:12 UTC (permalink / raw)
To: Florian Weimer; +Cc: Andreas Schwab, Alexey Brodkin, libc-alpha, linux-snps-arc
On Mon, 30 Jul 2018, Florian Weimer wrote:
> > There are a lot of tests that set TIMEOUT to less than 20.
>
> We should fix all of them.
It's conceivable some are deliberately less than 20 (if e.g. the test
sleeps for a certain number of seconds and does nothing else that should
take a significant amount of time), but certainly in the absence of a
reason for a short timeout I think such settings should be removed.
--
Joseph S. Myers
joseph@codesourcery.com
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-07-30 17:12 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-30 15:28 [PATCH] tst-tzset: raise timeout to 10 seconds Alexey Brodkin
2018-07-30 15:58 ` Joseph Myers
2018-07-30 16:07 ` Andreas Schwab
2018-07-30 16:51 ` Florian Weimer
2018-07-30 17:12 ` Joseph Myers
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).