From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 54027 invoked by alias); 17 Sep 2018 22:19:14 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 54007 invoked by uid 89); 17 Sep 2018 22:19:13 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:429, pow X-HELO: relay1.mentorg.com Date: Mon, 17 Sep 2018 22:19:00 -0000 From: Joseph Myers To: Szabolcs Nagy CC: GNU C Library , Subject: Re: [PATCH 3/3] Add new pow implementation In-Reply-To: Message-ID: References: <391ac2f9-9ee4-ac23-b791-09f0438c2b91@arm.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-SW-Source: 2018-09/txt/msg00263.txt.bz2 On Tue, 11 Sep 2018, Szabolcs Nagy wrote: > +/* Returns 0 if not int, 1 if odd int, 2 if even int. */ > +static inline int > +checkint (uint64_t iy) The comment needs to explain that this function is not called with an argument representing floating-point 0, Inf or NaN (since it wouldn't be correct for 0 at least). OK with that change. -- Joseph S. Myers joseph@codesourcery.com