From: Joseph Myers <joseph@codesourcery.com>
To: Florian Weimer <fweimer@redhat.com>
Cc: Wilco Dijkstra <Wilco.Dijkstra@arm.com>,
"libc-alpha@sourceware.org" <libc-alpha@sourceware.org>,
nd <nd@arm.com>
Subject: Re: [PATCH] Introduce --enable-math-noprivate
Date: Thu, 20 Sep 2018 17:11:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.21.1809201659480.3377@digraph.polyomino.org.uk> (raw)
In-Reply-To: <878t3wumw5.fsf@oldenburg.str.redhat.com>
On Thu, 20 Sep 2018, Florian Weimer wrote:
> > Similarly the strtod_nan* dependency seems worthwhile to remove too.
>
> I haven't thought about this. It's certainly a bit of a code
> duplication.
>
> Joseph, any thoughts on that?
Well, sharing the implementation of NaN parsing between the nan functions
and the strto* functions seemed to make sense (the old approach of the nan
functions calling strto* having had problems as discussed in bugs 16961
and 16962). And to share it at the binary level, not just the source
level, meant GLIBC_PRIVATE exports. Since such exports are completely
normal as the way for one glibc library to use internal functionality from
another, I see no obvious reason to avoid using them by default, as
opposed to with non-default configure options like this one.
There's potential for the functions to get more complicated in the
_Float128 / binary128 long double case - the present approach is unable to
represent NaN significand bits outside the trailing 64 (and fixing that
would mean having something like strtoull that handles integers up to at
least 111 bits - in which case either that something would need exporting
from libc as public, or it would need exporting as GLIBC_PRIVATE and
duplicating with the new option). (You can construct NaNs with arbitrary
payloads using setpayload functions, but having the nan/strto functions be
able to do so as well would seem natural.)
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2018-09-20 17:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-20 16:27 Wilco Dijkstra
2018-09-20 16:35 ` Joseph Myers
2018-09-20 16:58 ` Florian Weimer
2018-09-20 17:11 ` Joseph Myers [this message]
2018-09-20 17:25 ` Florian Weimer
2018-09-20 17:35 ` Joseph Myers
-- strict thread matches above, loose matches on Subject: below --
2018-09-20 14:01 Florian Weimer
2018-05-11 15:43 Florian Weimer
2018-05-11 16:36 ` Adhemerval Zanella
2018-05-11 17:23 ` Florian Weimer
2018-05-16 4:54 ` Florian Weimer
2018-06-07 13:38 ` Florian Weimer
2018-06-08 9:03 ` Szabolcs Nagy
2018-06-08 11:22 ` Adhemerval Zanella
2018-06-08 12:12 ` Florian Weimer
2018-06-08 12:56 ` Adhemerval Zanella
2018-06-08 12:11 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1809201659480.3377@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=Wilco.Dijkstra@arm.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).