From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 96088 invoked by alias); 26 Sep 2018 16:14:14 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 96076 invoked by uid 89); 26 Sep 2018 16:14:13 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: relay1.mentorg.com Date: Wed, 26 Sep 2018 16:14:00 -0000 From: Joseph Myers To: "Albert ARIBAUD (3ADEV)" CC: Subject: Re: [PATCH v8 2/2] Y2038: make __tz_convert compatible with 64-bit-time In-Reply-To: <20180926073053.11710-2-albert.aribaud@3adev.fr> Message-ID: References: <20180926073053.11710-1-albert.aribaud@3adev.fr> <20180926073053.11710-2-albert.aribaud@3adev.fr> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-SW-Source: 2018-09/txt/msg00488.txt.bz2 On Wed, 26 Sep 2018, Albert ARIBAUD (3ADEV) wrote: > Now that __time_64_t exists, we can switch internal function > __tz_convert from 32-bit to 64-bit time. This involves switching > some other internal functions and turning some implementations > which use these into wrappers between public 32-bit and internal > 64-bit time. You're missing the information about what platforms this patch was tested on with the full glibc testsuite. That's critical information for such a patch submission, which needs testing on both 32-bit and 64-bit platforms. (Later patches supporting using new syscalls will need testing on additional configurations, including building with old kernel headers; building with kernel headers with the new syscalls but running on a kernel without them; and building with new kernel headers and running on a kernel with the new syscalls.) -- Joseph S. Myers joseph@codesourcery.com