From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 39541 invoked by alias); 13 Dec 2018 20:28:23 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 39526 invoked by uid 89); 13 Dec 2018 20:28:22 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=placing, austingroupbugsnet, UD:austingroupbugs.net, Hx-languages-length:1458 X-HELO: relay1.mentorg.com Date: Thu, 13 Dec 2018 22:27:00 -0000 From: Joseph Myers To: =?ISO-8859-15?Q?Jan_Kl=F6tzke?= CC: Subject: Re: [PATCH] Semaphores: add sem_timedwait_monotonic GNU extension [BZ #14717] In-Reply-To: <20181213200009.22246-1-jan@kloetzke.net> Message-ID: References: <20181213200009.22246-1-jan@kloetzke.net> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="-1152306461-811759162-1544732892=:10832" X-SW-Source: 2018-12/txt/msg00473.txt.bz2 ---1152306461-811759162-1544732892=:10832 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Content-length: 1390 On Thu, 13 Dec 2018, Jan Klötzke wrote: > The added sem_timedwait_monotonic() function behaves just like > sem_timedwait() but is based on CLOCK_MONOTONIC. An identically named > function is already provided by QNX for the same reasons. My understanding from the Austin Group discussion was that the preferred approach was functions with "clock" instead of "timed" in their names, taking a clockid parameter (so sem_clockwait in this case). http://austingroupbugs.net/view.php?id=1216 Note that new functions need a NEWS entry. They also need testcases; I don't see any in this patch. How has this patch been tested? I'd have expected it to fail the ABI tests, because > diff --git a/sysdeps/unix/sysv/linux/x86_64/64/libpthread.abilist b/sysdeps/unix/sysv/linux/x86_64/64/libpthread.abilist > index 931c8277a8..a69993f4d9 100644 > --- a/sysdeps/unix/sysv/linux/x86_64/64/libpthread.abilist > +++ b/sysdeps/unix/sysv/linux/x86_64/64/libpthread.abilist > @@ -254,3 +254,4 @@ GLIBC_2.4 pthread_mutexattr_getrobust_np F > GLIBC_2.4 pthread_mutexattr_setprioceiling F > GLIBC_2.4 pthread_mutexattr_setprotocol F > GLIBC_2.4 pthread_mutexattr_setrobust_np F > +GLIBC_2.29 sem_timedwait_monotonic F (for example) is not placing the new entry in its correct (LC_ALL=C) sorted location. Are you covered by an FSF copyright assignment? -- Joseph S. Myers joseph@codesourcery.com ---1152306461-811759162-1544732892=:10832--