From: Joseph Myers <joseph@codesourcery.com>
To: Girish Joshi <girish946@gmail.com>
Cc: <libc-alpha@sourceware.org>
Subject: Re: [PATCH] argp: argp.doc prints incorrectly when it starts with "\v" [BZ #19038]
Date: Thu, 25 Jul 2019 15:33:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.21.1907251528470.5744@digraph.polyomino.org.uk> (raw)
In-Reply-To: <CALkY8p8Es6bDy_cArL-EAXL_NQiJu0r+nSF=X26Yw3DxmEzP+w@mail.gmail.com>
On Fri, 5 Jul 2019, Girish Joshi wrote:
> diff --git a/argp/tst-argp-help.c b/argp/tst-argp-help.c
> new file mode 100644
> index 0000000000..3bfeb0219c
> --- /dev/null
> +++ b/argp/tst-argp-help.c
> @@ -0,0 +1,39 @@
> +/* Copyright (C) 2002-2019 Free Software Foundation, Inc.
> + This file is part of the GNU C Library.
Are you sure this has copyrightable content dating from 2002?
> + Contributed by Girish Joshi <girish946@gmail.com>, 2019.
We don't put "Contributed by" in any new files, and haven't for several
years.
> + /* Parse and process arguments. */
> + argp_parse(&argp, argc, argv, 0, &remaining, NULL);
Please use GNU style, i.e. space before '('. There are also coding style
issues in the changes to argp-help.c (braces in the wrong place).
I'm not clear how this test verifies that the results are as expected,
i.e. how it ensures that, if the change to argp-help.c is not present, the
test FAILs.
I'm also not clear what the actual issue being fixed is. Please make sure
to include a git-style commit message in any patch submission that
provides a self-contained explanation of the problem and how it is fixed.
> +#define TEST_FUNCTION do_test ()
> +#include "../test-skeleton.c"
New tests should not use the old-style test-skeleton.c. See
support/README-testing.c.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2019-07-25 15:33 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-06 8:55 Girish Joshi
2019-05-06 12:37 ` Florian Weimer
2019-05-06 13:38 ` Girish Joshi
2019-05-30 8:14 ` Girish Joshi
2019-05-30 12:52 ` Adhemerval Zanella
2019-07-05 9:02 ` Girish Joshi
2019-07-05 10:35 ` Girish Joshi
2019-07-25 15:33 ` Joseph Myers [this message]
2019-11-25 18:08 ` Girish Joshi
2019-11-30 14:47 ` Girish Joshi
2019-11-30 15:05 ` Carlos O'Donell
2020-01-07 17:55 ` Girish Joshi
2020-01-20 17:39 ` Girish Joshi
2020-01-24 2:59 ` Carlos O'Donell
2020-02-11 18:40 ` Girish Joshi
2020-02-20 7:09 ` Girish Joshi
2020-03-03 18:13 Girish Joshi
2020-03-19 19:38 ` Girish Joshi
2020-03-21 2:03 ` DJ Delorie
2020-03-25 17:55 ` Girish Joshi
2020-05-07 19:53 ` Girish Joshi
2020-05-23 10:10 ` Girish Joshi
2020-06-14 15:50 ` Girish Joshi
2020-06-15 8:56 ` Florian Weimer
2020-06-15 9:51 ` Girish Joshi
2020-06-15 14:38 ` Zack Weinberg
2021-02-18 21:13 ` Girish Joshi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1907251528470.5744@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=girish946@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).