public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Joseph Myers <joseph@codesourcery.com>
To: Carlos O'Donell <carlos@redhat.com>
Cc: "Florian Weimer" <fweimer@redhat.com>,
	libc-alpha@sourceware.org, "Niklas Hambüchen" <mail@nh2.me>
Subject: Re: [PATCH] malloc: Fix missing accounting of top chunk in malloc_info [BZ #24026]
Date: Fri, 02 Aug 2019 19:54:00 -0000	[thread overview]
Message-ID: <alpine.DEB.2.21.1908021950540.22536@digraph.polyomino.org.uk> (raw)
In-Reply-To: <757d8c19-6f15-928c-1adf-d818d0347e7f@redhat.com>

On Fri, 2 Aug 2019, Carlos O'Donell wrote:

> > Writing a test case for this would unfortunately need an XML parser.
> > I don't know if we can use the one that comes with Python.
> 
> I don't see why we can't use 'import xml' to use the language
> provided XML parser.

It's the warning at 
<https://sourceware.org/glibc/wiki/Style_and_Conventions#Python_usage_conventions> 
about avoiding standard library modules depending on external libraries, 
to assist in bootstrap etc. configurations (bringing up native builds on a 
new system which might start without a full Python install).  However, (a) 
that's only for the build of glibc, testing glibc might use such modules 
provided it's appropriately conditional so tests end up as UNSUPPORTED if 
they are unavailable, and (b) the Python documentation says "The Expat 
parser is included with Python, so the xml.parsers.expat module will 
always be available.", which indicates that shouldn't be considered as 
depending on an external library anyway.

-- 
Joseph S. Myers
joseph@codesourcery.com

  parent reply	other threads:[~2019-08-02 19:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-01 12:12 Florian Weimer
2019-08-01 15:54 ` Carlos O'Donell
2019-08-01 16:36   ` Florian Weimer
2019-08-02 17:49     ` Carlos O'Donell
2019-08-02 19:03       ` DJ Delorie
2019-08-02 19:54       ` Joseph Myers [this message]
2019-08-02 20:35         ` DJ Delorie
2019-08-07 14:28       ` Florian Weimer
2019-08-08 18:21         ` Carlos O'Donell
2019-08-12  3:12           ` Niklas Hambüchen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.1908021950540.22536@digraph.polyomino.org.uk \
    --to=joseph@codesourcery.com \
    --cc=carlos@redhat.com \
    --cc=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    --cc=mail@nh2.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).