From: Joseph Myers <joseph@codesourcery.com>
To: Alistair Francis <alistair.francis@wdc.com>
Cc: <libc-alpha@sourceware.org>, <arnd@arndb.de>,
<adhemerval.zanella@linaro.org>, <fweimer@redhat.com>,
<palmer@sifive.com>, <macro@wdc.com>, <zongbox@gmail.com>,
<alistair23@gmail.com>
Subject: Re: [RFC v4 03/24] sysdeps/gettimeofday: Use clock_gettime64 if avaliable
Date: Mon, 12 Aug 2019 17:27:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.21.1908121723200.9732@digraph.polyomino.org.uk> (raw)
In-Reply-To: <1561c94daae983eb2380b9579d737146505f1a6f.1565398513.git.alistair.francis@wdc.com>
On Fri, 9 Aug 2019, Alistair Francis wrote:
> The Linux documentation says that "The use of the timezone structure
> is obsolete; the tz argument should normally be specified as NULL."
The relevant information to include in commit messages here isn't what the
documentation says, it's what the interfaces actually do, as detailed in
<https://sourceware.org/ml/libc-alpha/2019-07/msg00574.html>.
> __gettimeofday (struct timeval *tv, struct timezone *tz)
> +#ifdef __ASSUME_TIME64_SYSCALLS
> + long int ret;
> + struct timespec now;
> +
> + ret = INLINE_VSYSCALL (clock_gettime64, 2, CLOCK_REALTIME,
> + &now);
This is using a timespec (possibly 32-bit) with a syscall that requires
the 64-bit version. You need to address such issues throughout the patch
series. As illustrated here, it's not just cases where you have a
mismatch with the function interface; you need to make sure, in every
case, that where you pass internal variables to 64-bit time syscalls they
have the correct type as well.
> +#else
> +# ifdef __NR_clock_nanosleep_time64
No, this code isn't using clock_nanosleep_time64. The #ifdef should be
for the syscall it actually uses.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2019-08-12 17:27 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-10 1:03 [RFC v4 00/24] RISC-V glibc port for the 32-bit Alistair Francis
2019-08-10 1:03 ` [RFC v4 09/24] Documentation for the RISC-V 32-bit port Alistair Francis
2019-08-12 20:02 ` Joseph Myers
2019-08-10 1:03 ` [RFC v4 08/24] sysdeps/stat: Copy the statx struct to stat instead of stat64 Alistair Francis
2019-08-12 20:01 ` Joseph Myers
2019-08-12 22:26 ` Alistair Francis
2019-08-12 23:02 ` Joseph Myers
2019-08-12 23:10 ` Alistair Francis
2019-08-12 23:31 ` Joseph Myers
2019-08-13 20:40 ` Alistair Francis
2019-08-10 1:03 ` [RFC v4 16/24] RISC-V: The ABI implementation for the 32-bit Alistair Francis
2019-08-10 1:03 ` [RFC v4 10/24] RISC-V: Use 64-bit time_t and off_t for RV32 and RV64 Alistair Francis
2019-08-10 1:03 ` [RFC v4 06/24] sysdeps/timespec_get: Use clock_gettime64 if avaliable Alistair Francis
2019-08-12 19:46 ` Joseph Myers
2019-08-15 18:03 ` Alistair Francis
2019-08-15 19:46 ` Joseph Myers
2019-08-15 20:52 ` Alistair Francis
2019-08-15 20:59 ` Joseph Myers
2019-08-15 21:16 ` Alistair Francis
2019-08-15 21:19 ` Joseph Myers
2019-08-15 21:23 ` Alistair Francis
2019-08-15 21:28 ` Joseph Myers
2019-08-15 21:35 ` Alistair Francis
2019-08-10 1:03 ` [RFC v4 04/24] sysdeps/wait: Use waitid " Alistair Francis
2019-08-10 1:03 ` [RFC v4 01/24] sunrpc/clnt_udp: Ensure total_deadline is initalised Alistair Francis
2019-08-10 1:03 ` [RFC v4 03/24] sysdeps/gettimeofday: Use clock_gettime64 if avaliable Alistair Francis
2019-08-12 17:27 ` Joseph Myers [this message]
2019-08-10 1:03 ` [RFC v4 05/24] sysdeps/clock_gettime: " Alistair Francis
2019-08-12 19:46 ` Joseph Myers
2019-08-13 23:48 ` Alistair Francis
2019-08-14 16:37 ` Joseph Myers
2019-08-14 18:12 ` Alistair Francis
2019-08-10 1:03 ` [RFC v4 02/24] sysdeps/nanosleep: Use clock_nanosleep_time64 " Alistair Francis
2019-08-12 17:22 ` Joseph Myers
2019-08-14 18:24 ` Alistair Francis
2019-08-14 20:15 ` Joseph Myers
2019-08-14 21:39 ` Stepan Golosunov
2019-08-10 1:03 ` [RFC v4 07/24] time: Deprecate struct timezone members Alistair Francis
2019-08-10 1:20 ` Paul Eggert
2019-08-10 1:30 ` Alistair Francis
2019-08-11 13:52 ` Florian Weimer
2019-08-11 16:59 ` Alistair Francis
2019-08-11 17:28 ` Rich Felker
2019-08-12 8:22 ` Florian Weimer
2019-08-12 15:42 ` Zack Weinberg
2019-08-12 20:20 ` Joseph Myers
2019-08-12 21:08 ` Zack Weinberg
2019-08-12 21:26 ` Joseph Myers
2019-08-12 22:13 ` Alistair Francis
2019-08-12 23:16 ` Zack Weinberg
2019-08-13 0:53 ` Paul Eggert
2019-08-13 1:04 ` Zack Weinberg
2019-08-12 22:11 ` Alistair Francis
2019-08-10 1:03 ` [RFC v4 12/24] RISC-V: define __NR_* as __NR_*_time64/64 for 32-bit Alistair Francis
2019-08-10 1:03 ` [RFC v4 17/24] RISC-V: Hard float support for the 32 bit Alistair Francis
2019-08-10 1:03 ` [RFC v4 15/24] RISC-V: Add path of library directories for RV32 Alistair Francis
2019-08-10 1:03 ` [RFC v4 13/24] RISC-V: Use 64-bit timespec in clock_gettime vdso calls Alistair Francis
2019-08-10 1:04 ` [RFC v4 21/24] Add RISC-V 32-bit target to build-many-glibcs.py Alistair Francis
2019-08-10 1:04 ` [RFC v4 20/24] RISC-V: Fix llrint and llround missing exceptions on RV32 Alistair Francis
2019-08-10 1:04 ` [RFC v4 14/24] RISC-V: Support dynamic loader for the 32-bit Alistair Francis
2019-08-10 1:04 ` [RFC v4 24/24] timerfd_settime: Use 64-bit call if avaliable Alistair Francis
2019-08-10 1:28 ` Alistair Francis
2019-08-20 20:11 ` Maciej W. Rozycki
2019-08-12 20:09 ` Joseph Myers
2019-08-10 1:04 ` [RFC v4 23/24] WIP: syscall.list: Call 64-bit versions of syscalls Alistair Francis
2019-08-14 18:39 ` Alistair Francis
2019-08-14 18:57 ` Florian Weimer
2019-08-15 21:43 ` Alistair Francis
2019-08-19 11:30 ` Florian Weimer
2019-08-10 1:04 ` [RFC v4 18/24] RISC-V: Add ABI lists Alistair Francis
2019-08-10 1:04 ` [RFC v4 22/24] RISC-V: Use 64-bit vdso syscalls for RV32 Alistair Francis
2019-08-10 1:04 ` [RFC v4 19/24] RISC-V: Build Infastructure for the 32-bit Alistair Francis
2019-08-10 1:04 ` [RFC v4 11/24] RISC-V: define __NR_futex as __NR_futex_time64 for 32-bit Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1908121723200.9732@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=adhemerval.zanella@linaro.org \
--cc=alistair.francis@wdc.com \
--cc=alistair23@gmail.com \
--cc=arnd@arndb.de \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=macro@wdc.com \
--cc=palmer@sifive.com \
--cc=zongbox@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).