From: Joseph Myers <joseph@codesourcery.com>
To: Lukasz Majewski <lukma@denx.de>
Cc: Alistair Francis <alistair23@gmail.com>,
Alistair Francis <alistair.francis@wdc.com>,
GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH 2/2] time: Add padding for the timespec if required
Date: Wed, 25 Sep 2019 16:24:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.21.1909251622340.21121@digraph.polyomino.org.uk> (raw)
In-Reply-To: <20190925115016.1ac80af1@jawa>
On Wed, 25 Sep 2019, Lukasz Majewski wrote:
> > > > +#if __WORDSIZE == 64 \
> > > > + || (defined __SYSCALL_WORDSIZE && __SYSCALL_WORDSIZE == 64) ||
> > > > \
> > > > + __TIMESIZE == 32
> ^^^^^^^^^^^^^^^^^ - this may be a bit problematic as 32 bit
> systems (with __TIMESIZE == 32) gain support for 64 bit time
> (so the Y2038 problem is solved).
>
> Those systems also would require padding (the code below).
>
> However, I do guess that allowing such systems to have the
> extra padding after this patch (by removing __TIMESIZE==32
> condition) is not an option for now (and shall be done in the
> same commit which introduces -D_TIME_BITS=64 support to glibc)
> ?
Yes, support for _TIME_BITS=64 should end up as one large commit that adds
all the header support, all the function exports and symbol versions, all
the ABI baseline updates and all the documentation. (It may well be split
into several pieces to review, but should still end up as one commit to
avoid intermediate states where some interfaces have _TIME_BITS=64 support
and some don't, so compiling with _TIME_BITS=64 gives a broken ABI.)
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2019-09-25 16:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-25 0:33 [PATCH 1/2] Split up endian.h to minimize exposure of BYTE_ORDER Alistair Francis
2019-09-25 0:33 ` [PATCH 2/2] time: Add padding for the timespec if required Alistair Francis
2019-09-25 0:57 ` Joseph Myers
2019-09-25 1:02 ` Alistair Francis
2019-09-25 9:50 ` Lukasz Majewski
2019-09-25 16:24 ` Joseph Myers [this message]
2019-09-25 20:05 ` Lukasz Majewski
2019-09-25 7:34 ` [PATCH 1/2] Split up endian.h to minimize exposure of BYTE_ORDER Andreas Schwab
2019-09-25 22:54 ` Alistair Francis
2019-09-26 7:02 ` Andreas Schwab
2019-09-27 0:56 ` Alistair Francis
2019-09-27 15:38 ` Joseph Myers
2019-09-27 21:40 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1909251622340.21121@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=alistair.francis@wdc.com \
--cc=alistair23@gmail.com \
--cc=libc-alpha@sourceware.org \
--cc=lukma@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).