From: Joseph Myers <joseph@codesourcery.com>
To: Alistair Francis <alistair.francis@wdc.com>
Cc: <libc-alpha@sourceware.org>, <lukma@denx.de>, <alistair23@gmaill.com>
Subject: Re: [PATCH] sysdeps/nanosleep: Use clock_nanosleep_time64 if avaliable
Date: Thu, 17 Oct 2019 15:39:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.21.1910171537160.2642@digraph.polyomino.org.uk> (raw)
In-Reply-To: <20191017000829.4462-1-alistair.francis@wdc.com>
On Wed, 16 Oct 2019, Alistair Francis wrote:
> diff --git a/nptl/thrd_sleep.c b/nptl/thrd_sleep.c
> index 2e185dd748e..bd9373b1f61 100644
> --- a/nptl/thrd_sleep.c
> +++ b/nptl/thrd_sleep.c
> @@ -22,18 +22,79 @@
> #include "thrd_priv.h"
>
> int
> -thrd_sleep (const struct timespec* time_point, struct timespec* remaining)
> +__thrd_sleep_time64 (const struct __timespec64* time_point, struct __timespec64* remaining)
> {
> INTERNAL_SYSCALL_DECL (err);
> - int ret = INTERNAL_SYSCALL_CANCEL (nanosleep, err, time_point, remaining);
> + int ret = -1;
> +
> +#ifdef __ASSUME_TIME64_SYSCALLS
I'd prefer any file using __ASSUME_* macros to include <kernel-features.h>
explicitly. I think you're getting it here indirectly via
sysdep-cancel.h which includes sysdep.h, but I don't think it should be
defined as part of the API of sysdep-cancel.h that it must include
kernel-features.h, and until we move __ASSUME_* to being 0/1 rather than
undefined/defined, a missing include would just quietly mean the code
isn't built as intended.
The same applies to any other files with __ASSUME_* uses added in this or
other patches.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2019-10-17 15:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-17 0:13 Alistair Francis
2019-10-17 8:56 ` Lukasz Majewski
2019-10-17 17:16 ` Alistair Francis
2019-10-17 15:39 ` Joseph Myers [this message]
2019-10-17 16:53 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1910171537160.2642@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=alistair.francis@wdc.com \
--cc=alistair23@gmaill.com \
--cc=libc-alpha@sourceware.org \
--cc=lukma@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).