* [PATCH] Include <kernel-features.h> explicitly in Linux clock_settime.c
@ 2019-10-18 13:46 Lukasz Majewski
2019-10-18 15:18 ` Joseph Myers
0 siblings, 1 reply; 2+ messages in thread
From: Lukasz Majewski @ 2019-10-18 13:46 UTC (permalink / raw)
To: Joseph Myers
Cc: Alistair Francis, Alistair Francis, GNU C Library, Lukasz Majewski
The rewritten clock_settime code (which now supports 64 bit time on systems
with __WORDSIZE == 32) for Linux now relies on the
__ASSUME_TIME64_SYSCALLS flag set.
Lets explicitly include the header file where it is defined to avoid
any indirect inclusion (which may pose some unwanted API definitions).
Tested with scripts/build-many-glibcs.py script.
---
sysdeps/unix/sysv/linux/clock_settime.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sysdeps/unix/sysv/linux/clock_settime.c b/sysdeps/unix/sysv/linux/clock_settime.c
index fb48de5d50..54999d3008 100644
--- a/sysdeps/unix/sysv/linux/clock_settime.c
+++ b/sysdeps/unix/sysv/linux/clock_settime.c
@@ -19,6 +19,7 @@
#include <sysdep.h>
#include <time.h>
#include <shlib-compat.h>
+#include <kernel-features.h>
/* Set CLOCK to value TP. */
int
--
2.20.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Include <kernel-features.h> explicitly in Linux clock_settime.c
2019-10-18 13:46 [PATCH] Include <kernel-features.h> explicitly in Linux clock_settime.c Lukasz Majewski
@ 2019-10-18 15:18 ` Joseph Myers
0 siblings, 0 replies; 2+ messages in thread
From: Joseph Myers @ 2019-10-18 15:18 UTC (permalink / raw)
To: Lukasz Majewski; +Cc: Alistair Francis, Alistair Francis, GNU C Library
On Fri, 18 Oct 2019, Lukasz Majewski wrote:
> The rewritten clock_settime code (which now supports 64 bit time on systems
> with __WORDSIZE == 32) for Linux now relies on the
> __ASSUME_TIME64_SYSCALLS flag set.
>
> Lets explicitly include the header file where it is defined to avoid
> any indirect inclusion (which may pose some unwanted API definitions).
>
> Tested with scripts/build-many-glibcs.py script.
OK, please commit.
--
Joseph S. Myers
joseph@codesourcery.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-18 15:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-18 13:46 [PATCH] Include <kernel-features.h> explicitly in Linux clock_settime.c Lukasz Majewski
2019-10-18 15:18 ` Joseph Myers
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).