From: Joseph Myers <joseph@codesourcery.com>
To: Lukasz Majewski <lukma@denx.de>
Cc: "GNU C Library" <libc-alpha@sourceware.org>, <libc-help@sourceware.org>
Subject: Re: Problem with conformance test and header files inclusion for ./include/sys/poll.h
Date: Thu, 31 Oct 2019 23:13:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.21.1910312311200.28010@digraph.polyomino.org.uk> (raw)
In-Reply-To: <20191101000843.00e86185@jawa>
On Fri, 1 Nov 2019, Lukasz Majewski wrote:
> This seems to be caused by adding
>
> # include <time.h> (or even #include <include/time.h>) [*]
> # include <signal.h> (or even #include <include/signal.h>) [*]
Everything in an include/ header other than the include of the
corresponding public header needs to be inside "#ifndef _ISOMAC".
> [****] - A bit off topic: What is the purpose of -D_ISOMAC define? It
> can be found in glibc's sources in several places (e.g. # ifndef
> _ISOMAC).
The purpose is to cause the include/ header wrappers to define only what
the installed headers would define, not anything internal to glibc. This
is used by most tests (all except those in tests-internal), including the
header conformance ones.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2019-10-31 23:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-31 23:08 Lukasz Majewski
2019-10-31 23:13 ` Joseph Myers [this message]
2019-10-31 23:53 ` Lukasz Majewski
2019-11-01 0:18 ` Joseph Myers
2019-11-01 10:12 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1910312311200.28010@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=libc-help@sourceware.org \
--cc=lukma@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).