From: Joseph Myers <joseph@codesourcery.com>
To: Carlos O'Donell <carlos@redhat.com>
Cc: Andreas Schwab <schwab@suse.de>,
libc-alpha <libc-alpha@sourceware.org>,
Paul Eggert <eggert@cs.ucla.edu>
Subject: Re: Steward opinions on gerrit?
Date: Wed, 27 Nov 2019 22:47:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.21.1911272242050.14409@digraph.polyomino.org.uk> (raw)
In-Reply-To: <8c2b7a9d-adfc-813c-eeb0-634409fe917f@redhat.com>
On Wed, 27 Nov 2019, Carlos O'Donell wrote:
> As stewards for glibc I wanted to ask each of you if you had
> any opinions on gerrit, and thoughts on or the fundamental
> requirements of a review system for a project like glibc.
>
> Joseph,
>
> You write and review a lot of patches. Does using gerrit
> interest you? Does it solve any problems?
I'm not convinced the experiment is advanced enough to tell whether it
helps much. The main problem I see patch review systems as being for is
to track changes that are under consideration but not yet approved, and
it's hard to judge when there are only a few changes in there. (I suspect
any system would gradually accumulate patches that were submitted by
one-off contributors, issues raised, but never revised and never
definitively rejected either.)
There's potential for various kinds of CI integration with patch tracking,
but I don't think we've tried that.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2019-11-27 22:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 20:00 Carlos O'Donell
2019-11-27 22:47 ` Joseph Myers [this message]
2019-12-02 17:21 ` Carlos O'Donell
2019-12-09 10:54 ` Andreas Schwab
2019-12-09 12:39 ` Carlos O'Donell
2019-12-09 12:54 ` Andreas Schwab
2019-12-09 17:23 ` Carlos O'Donell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1911272242050.14409@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=carlos@redhat.com \
--cc=eggert@cs.ucla.edu \
--cc=libc-alpha@sourceware.org \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).