From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-107713-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 114852 invoked by alias); 4 Dec 2019 13:20:51 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 114486 invoked by uid 89); 4 Dec 2019 13:20:50 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=
X-HELO: esa4.mentor.iphmx.com
IronPort-SDR: 7dOxzC8eVxgnQS2UsArRPSDvcPVfpyNAkP1dkydWBa6J/0/uJIilpB+kMs2HzhUE03CHdQ14fZ
 SAVxxJ/zw6qhtJOPzvDzQECROV+jQJjEU38HOJIYJtdjTL6E+9t8W+xMh6LmW+ajetAVdrbyfR
 nCtxLK68nQjHt99btPsns7tM3lbcs7EKekktCJDBirC1JBWz6BIAFpoxOtcrSp1TICfrxT4I7Y
 1pYKLdmu/nwfXNr1ErblovIvOeFc4FJ9XHj1j7pxQ9RzErgWY1fwiZLqIbz8J93yh6ul1U67Xi
 Alc=
IronPort-SDR: 8NNo9DgnX8jeOWdICeeB1nyuEy0dcpmnivf87HAyPBpu+fWkKZpQZTVL5PG4u978inSsab3zxs
 yJRmehVJH892pln4W6uZyOa9az4qW0Yh1HfUbFAz9Od6fh3EPbQrllMBuxh4TCDcG0/jlcz7i8
 fhxqnrTjEmPO/2JN3NOdiKOKFZzXQXfLLUTcXq0UFRrynJFF3z0JSFU7r6pqt83b8F6ak0n0p6
 Ti4PvFLZM1wlv9iNAWHwyjNbzB4ZoSAkiuy9qQWtU2Jd4NWQoGWnZlYG3gsD5Ewgzxy8bBUARd
 AlM=
Date: Wed, 04 Dec 2019 13:20:00 -0000
From: Joseph Myers <joseph@codesourcery.com>
To: Stefan Liebler <stli@linux.ibm.com>
CC: <libc-alpha@sourceware.org>
Subject: Re: [PATCH 13/13] Use GCC builtins for copysign functions if
 desired.
In-Reply-To: <e24d1f79-2402-d7cd-f80a-50be7ebad2b8@linux.ibm.com>
Message-ID: <alpine.DEB.2.21.1912041320080.19057@digraph.polyomino.org.uk>
References: <1575297977-2589-1-git-send-email-stli@linux.ibm.com> <1575297977-2589-14-git-send-email-stli@linux.ibm.com> <alpine.DEB.2.21.1912022059030.23075@digraph.polyomino.org.uk> <e3c29fb8-5a63-0a0a-a55c-3d7751b348b1@linux.ibm.com>
 <alpine.DEB.2.21.1912031648200.14275@digraph.polyomino.org.uk> <e24d1f79-2402-d7cd-f80a-50be7ebad2b8@linux.ibm.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Return-Path: joseph@codesourcery.com
X-SW-Source: 2019-12/txt/msg00145.txt.bz2

On Wed, 4 Dec 2019, Stefan Liebler wrote:

> > I think they can all be 1, given that IBM long double has its own
> > implementation.  Except that you shouldn't need the indirection through
> > these macros at all.  Just use __builtin_copysign etc. directly in the
> > implementations (other than IBM long double), unconditionally, the same
> > way that sysdeps/ieee754/dbl-64/s_fabs.c uses __builtin_fabs directly
> > without such macros being needed.
> > 
> 
> Okay. I've set them to 1 and also used build-many-glibcs.py and had a look
> into the s_copysign*.os files. There is no function call to copysign* itself.

I think we should handle this like fabs and not have the macros at all, 
just call __builtin_copysign etc. unconditionally.

-- 
Joseph S. Myers
joseph@codesourcery.com