From: Joseph Myers <joseph@codesourcery.com>
To: Vineet Gupta <Vineet.Gupta1@synopsys.com>
Cc: <libc-alpha@sourceware.org>, <linux-snps-arc@lists.infradead.org>,
<alistair.francis@wdc.com>, <alistair23@gmail.com>
Subject: Re: [PATCH v2] asm-generic ABI: Allow statx syscall despite fstatat64,fstat64
Date: Tue, 25 Feb 2020 00:10:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.21.2002250008160.23654@digraph.polyomino.org.uk> (raw)
In-Reply-To: <20200224221530.12928-1-vgupta@synopsys.com>
On Mon, 24 Feb 2020, Vineet Gupta wrote:
> diff --git a/sysdeps/unix/sysv/linux/fxstat64.c b/sysdeps/unix/sysv/linux/fxstat64.c
> index 9133a0a29b8e..93394c450f1c 100644
> --- a/sysdeps/unix/sysv/linux/fxstat64.c
> +++ b/sysdeps/unix/sysv/linux/fxstat64.c
> @@ -33,15 +33,15 @@ int
> ___fxstat64 (int vers, int fd, struct stat64 *buf)
> {
> int result;
> -#ifdef __NR_fstat64
> - result = INLINE_SYSCALL (fstat64, 2, fd, buf);
> -#else
> +# if STAT64_IS_NOT_KERNEL_STAT64 || !defined(__NR_fstat64)
I don't think the extra space after "#" is correct here. We use such
spaces to indicate the level of nesting inside outer #if conditionals, but
there is no outer #if conditional around this one in this file, so "#if"
without the space is correct.
There should be a space before '(' in the "defined" call.
Likewise in other files changed by this patch.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2020-02-25 0:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 18:23 [PATCH] " Vineet Gupta
2020-02-24 18:39 ` Florian Weimer
2020-02-24 19:03 ` Vineet Gupta
2020-02-24 19:13 ` Florian Weimer
2020-02-24 19:27 ` Vineet Gupta
2020-02-24 19:38 ` Florian Weimer
2020-02-24 22:15 ` [PATCH v2] " Vineet Gupta
2020-02-25 0:10 ` Joseph Myers [this message]
2020-02-25 0:29 ` [PATCH v3] " Vineet Gupta
2020-02-25 3:13 ` [PATCH v3] asm-generic ABI: Allow statx syscall despite fstatat64, fstat64 Vineet Gupta
2020-02-25 16:10 ` Joseph Myers
2020-02-25 16:56 ` Vineet Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2002250008160.23654@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=Vineet.Gupta1@synopsys.com \
--cc=alistair.francis@wdc.com \
--cc=alistair23@gmail.com \
--cc=libc-alpha@sourceware.org \
--cc=linux-snps-arc@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).