From: Joseph Myers <joseph@codesourcery.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: <libc-alpha@sourceware.org>
Subject: Re: [PATCH 4/4] math: Remove inline math tests
Date: Thu, 19 Mar 2020 00:36:33 +0000 [thread overview]
Message-ID: <alpine.DEB.2.21.2003190034430.10208@digraph.polyomino.org.uk> (raw)
In-Reply-To: <02333672-cd59-41c4-fe0d-fd84f9732340@linaro.org>
On Wed, 18 Mar 2020, Adhemerval Zanella via Libc-alpha wrote:
> On 17/03/2020 19:51, Joseph Myers wrote:
> > On Tue, 17 Mar 2020, Adhemerval Zanella via Libc-alpha wrote:
> >
> >> With mathinline removal there is no need to keep building and testing
> >> inline math tests.
> >
> > There's more to remove there. All the libm-test-ulps files should no
> > longer have the "ifloat" etc. ulps. Those names should be removed from
> > ALL_FLOATS in gen-libm-tests.py. The support for generating ULP_I_*
> > macros in gen-libm-test.py should be removed. Support for no-test-inline
> > in gen-auto-libm-tests should be removed, no-test-inline should be removed
> > from relevant lines in auto-libm-test-in, corresponding
> > auto-libm-test-out-* files should be regenerated.
> >
>
> Thanks, updated patch below.
OK.
I think there are still references to __NO_MATH_INLINES in the source tree
after this patch that should be removed once the removal of
bits/mathinline.h and bits/fenvinline.h is complete.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2020-03-19 0:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-17 19:01 [PATCH 1/4] m68k: Remove mathinline.h Adhemerval Zanella
2020-03-17 19:01 ` [PATCH 2/4] math: Remove mathinline Adhemerval Zanella
2020-03-17 20:52 ` Andreas Schwab
2020-03-17 19:01 ` [PATCH 3/4] Remove __LIBC_INTERNAL_MATH_INLINES Adhemerval Zanella
2020-03-17 20:52 ` Andreas Schwab
2020-03-17 19:01 ` [PATCH 4/4] math: Remove inline math tests Adhemerval Zanella
2020-03-17 20:53 ` Andreas Schwab
2020-03-17 22:51 ` Joseph Myers
2020-03-18 14:36 ` Adhemerval Zanella
2020-03-19 0:36 ` Joseph Myers [this message]
2020-03-19 11:30 ` Adhemerval Zanella
2020-03-17 20:51 ` [PATCH 1/4] m68k: Remove mathinline.h Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2003190034430.10208@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).