From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa2.mentor.iphmx.com (esa2.mentor.iphmx.com [68.232.141.98]) by sourceware.org (Postfix) with ESMTPS id 31931385BF83 for ; Tue, 31 Mar 2020 21:22:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 31931385BF83 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=joseph_myers@mentor.com IronPort-SDR: 7bd9VyGPZHOdyTD7bBQy8AJpkLLiygClMJVZ/T8i4Rz/hvGMCBSS+oeM4ygDQX4gDA0SfjXlwY UdLNLhaSwKkCVtbADdQNNym0ftcBlkl+1hHBtEYdPcpFIPjAOqGhwTe9aWNVsKxSnxOaYiw0X2 WFFd59kKBsLEuUaVUm2u9bk/Yo0x9iFq85yYjJiCkW5V0bq6c+T4/weKsQ2QLvMXOxH5pSDlZB FhDF6+qheQYASR1zZnrOVkhBLDCGvLa0TKKPlu3pgrNvVcJuyrTDvfVw5ZN8APdQ2fssR1ureB mk0= X-IronPort-AV: E=Sophos;i="5.72,329,1580803200"; d="scan'208";a="47231021" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa2.mentor.iphmx.com with ESMTP; 31 Mar 2020 13:22:51 -0800 IronPort-SDR: CyqP8o4QaHFUUJmC2Nro+9t43lWaCQNsRh5ToTuOhouL+B5VItI9PmktiNSmsH8SBl4ovaVhrH fEnmog0AzQWZ8yAJ5zRqYj0FmcQY7ykate4ZUJRgKwxIyd/3w8r2iravxZ/D7Pe6dXjaRxjOxp TSHoMuJj3cgb2YY89kW2MDGTYn0MY/yjX3yXTeasSqt23YekrS3loXSL21EYN/UZxSDFQs6V9p sEGIsrYcq3JJnKOeppjMtiuC2FWMqkyCMTbbutSNZyjMP/J1Vqci3WyPDeVHgRpS15bZoN79Cd jaw= Date: Tue, 31 Mar 2020 21:22:45 +0000 From: Joseph Myers X-X-Sender: jsm28@digraph.polyomino.org.uk To: Vineet Gupta CC: Florian Weimer , Stepan Golosunov , Vineet Gupta via Libc-alpha , "linux-snps-arc@lists.infradead.org" , Alistair Francis Subject: Re: [PATCH] provide y2038 safe socket constants In-Reply-To: <10f0a47d-189d-14f2-f665-5b5532be629b@synopsys.com> Message-ID: References: <20200329041612.4071-1-vgupta@synopsys.com> <87r1x8qpx6.fsf@mid.deneb.enyo.de> <10f0a47d-189d-14f2-f665-5b5532be629b@synopsys.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: SVR-IES-MBX-08.mgc.mentorg.com (139.181.222.8) To SVR-IES-MBX-03.mgc.mentorg.com (139.181.222.3) X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Mar 2020 21:22:53 -0000 On Tue, 31 Mar 2020, Vineet Gupta via Libc-alpha wrote: > On 3/31/20 1:45 PM, Joseph Myers wrote: > > I'm concerned the present patch is wrong for x32, however; that has > > __TIMESIZE == 64 && __WORDSIZE == 32 but should use the old values; the > > patch should be using __SYSCALL_WORDSIZE when available in place of > > __WORDSIZE. > > Something like below ? > > -#if __TIMESIZE == 64 && __WORDSIZE == 32 > > +#if TIMESIZE == 64 && (__WORDSIZE == 32 \ > && (!defined __SYSCALL_WORDSIZE || __SYSCALL_WORDSIZE == 32)) Yes, that sort of thing. -- Joseph S. Myers joseph@codesourcery.com