From: Joseph Myers <joseph@codesourcery.com>
To: paul zimmermann <Paul.Zimmermann@inria.fr>
Cc: <libc-alpha@sourceware.org>
Subject: Re: faster exp10f code
Date: Tue, 7 Apr 2020 20:36:14 +0000 [thread overview]
Message-ID: <alpine.DEB.2.21.2004072032160.15873@digraph.polyomino.org.uk> (raw)
In-Reply-To: <mwo8s496iy.fsf@tomate.loria.fr>
On Mon, 6 Apr 2020, paul zimmermann wrote:
> I disabled the code in math/w_exp10f_compat.c by adding #if 0 ... #endif
> around it, since I don't know how to properly do it.
I'd expect symbol versioning like for expf. So
#if LIBM_SVID_COMPAT && SHLIB_COMPAT (libm, GLIBC_2_0, GLIBC_2_32)
in w_exp10f_compat.c, and math/w_exp10f.c using symbol versioning with
GLIBC_2_32 version, and sysdeps/ieee754/w_expf.c overriding that with a
dummy file, and e_expf.c using a GLIBC_2_32 symbol version, and
math/Versions being updated with the new symbol version, and all the ABI
test baselines being updated as well.
Everything apart from the benchtests will need to go in a single commit
(thus a single patch in the submission), rather than having later patches
fix up problems with earlier ones, on the principle of bisectability.
Benchtests can go in a separate commit.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2020-04-07 20:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-06 11:51 paul zimmermann
2020-04-07 20:36 ` Joseph Myers [this message]
2020-04-07 20:45 ` Joseph Myers
2020-04-08 10:15 ` paul zimmermann
2020-04-08 11:35 ` Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2004072032160.15873@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=Paul.Zimmermann@inria.fr \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).