From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa1.mentor.iphmx.com (esa1.mentor.iphmx.com [68.232.129.153]) by sourceware.org (Postfix) with ESMTPS id F12303851C10 for ; Tue, 28 Apr 2020 15:03:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org F12303851C10 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=joseph_myers@mentor.com IronPort-SDR: d9a3CsoiDCY9ir1ppb4F6kKWMW+Cn8U6fEt7ntBb3xwndccUARhjQAS0fQNfnv85/sHp29s8M4 sHyaJarl2K0lwWCbumYAj/O/N5IWzqRTADMsiFKBgGD8TpnQz/VKNO/0CAQtUI4ujc186BUgze qXF6A45xRqxxWqx7L2ta2GXNiq0uocf4Oi4NcVPnKaw1oValhBdI3/JGEZ0pGMNqwOSHRbzces axUiV/4OaUhS3i9oicPb7ohXP4K+mR05ffDgxt/9L4IXdvCIJ6YebR+i9Ltr+G5qtPOfiYsAOQ c6M= X-IronPort-AV: E=Sophos;i="5.73,328,1583222400"; d="scan'208";a="50320007" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa1.mentor.iphmx.com with ESMTP; 28 Apr 2020 07:03:12 -0800 IronPort-SDR: nI+4SLuslFcWWrCjAfa7ipi7sY45ziLDOMt4EAWaIsUtTTopUjF0xFwex8eaUb5C+WZk9ExNJH mncQkFLWsTkWW0mTPnxrySjbxkgrC746i6g7Nz1yujfXl/8BaS58eEnP3MzU+TJXP4C8ddAUTV s0+eW3bgfAKHjKCnFZPpTqM488FYUsPOtsI01Fz74HqQBIcEsqsXqYtz4lVtb0JgSL23K3P5r1 XRJQwUMLLf7272sB1tabpm/eZXRhlGLa1ZiEX/Fu/C9M479wpTVxD2M/vZofFbGjlbrOaOYmSt Ar8= Date: Tue, 28 Apr 2020 15:03:06 +0000 From: Joseph Myers X-X-Sender: jsm28@digraph.polyomino.org.uk To: Florian Weimer CC: =?ISO-8859-15?Q?Alexandra_H=E1jkov=E1_via_Libc-alpha?= , =?ISO-8859-15?Q?Alexandra_H=E1jkov=E1?= Subject: Re: [PATCH] Linux: Add execveat system call wrapper In-Reply-To: <87lfmfpudv.fsf@mid.deneb.enyo.de> Message-ID: References: <20200428122019.26826-1-ahajkova@redhat.com> <87lfmfpudv.fsf@mid.deneb.enyo.de> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: SVR-IES-MBX-07.mgc.mentorg.com (139.181.222.7) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-Spam-Status: No, score=-19.8 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Apr 2020 15:03:47 -0000 On Tue, 28 Apr 2020, Florian Weimer wrote: > * Alexandra Hájková via Libc-alpha: > > > diff --git a/sysdeps/mach/hurd/i386/libc.abilist b/sysdeps/mach/hurd/i386/libc.abilist > > index 60696d827f..571c281b06 100644 > > --- a/sysdeps/mach/hurd/i386/libc.abilist > > +++ b/sysdeps/mach/hurd/i386/libc.abilist > > @@ -2182,6 +2182,7 @@ GLIBC_2.3.4 xdr_quad_t F > > GLIBC_2.3.4 xdr_u_quad_t F > > GLIBC_2.30 twalk_r F > > GLIBC_2.32 mach_print F > > +GLIBC_2.32 execveat F > > GLIBC_2.32 thrd_current F > > GLIBC_2.32 thrd_equal F > > GLIBC_2.32 thrd_sleep F > > diff --git a/sysdeps/unix/sysv/linux/Makefile b/sysdeps/unix/sysv/linux/Makefile > > This is not correct because you are not adding execveat for Hurd. You > can just remove that change. First, the commit message should discuss the rationale for this being a Linux-specific interface in glibc, as opposed to an OS-independent interface with an ENOSYS stub for OSes that don't implement it. The interface looks quite generic like the POSIX *at interfaces, so there's a reasonable case for it being an OS-independent interface (which doesn't require adding an implementation for Hurd, an ENOSYS stub in a suitable OS-independent directory would suffice, along with the declaration, test etc. being OS-independent). -- Joseph S. Myers joseph@codesourcery.com