From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <joseph_myers@mentor.com>
Received: from esa4.mentor.iphmx.com (esa4.mentor.iphmx.com [68.232.137.252])
 by sourceware.org (Postfix) with ESMTPS id E17D9385DC0B
 for <libc-alpha@sourceware.org>; Tue, 28 Apr 2020 23:33:58 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E17D9385DC0B
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none)
 header.from=codesourcery.com
Authentication-Results: sourceware.org;
 spf=pass smtp.mailfrom=joseph_myers@mentor.com
IronPort-SDR: lKKLA8eSJCSAXhRZUKnw+ktpLMhT1JINj5DTa5qkqHTfgVFvupdvuHehK1y/QwECllVoiCQ1qi
 hU5fTJzsO9nscAFHZCutlOwYuXiy1DhzEcg5UjSnCoaFbIrATxijP7dOCMeTqqGPuCWvouANST
 5ArBF6SwFUUoeetZ0xSZ4WLXaHe+0bDRiajlJWgPnw8nPv8/kqa24wDohTpDI+LzxXAWT/avFu
 9wQ9ZMkmaDNjKgepNfW2Uy985M/zhasEy5RIzM7h56//h3XzhA48fea+x65908uiku1Q/EM3yq
 78E=
X-IronPort-AV: E=Sophos;i="5.73,328,1583222400"; d="scan'208";a="48390247"
Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165])
 by esa4.mentor.iphmx.com with ESMTP; 28 Apr 2020 15:33:58 -0800
IronPort-SDR: TvWpEMksDLO4Wi69bRX4ykoc2HkkUGAByna3xNsI7SRHxbtbBm2DhAWrSCRf0Vfd7k8gIDXAod
 rD5oa2H5CJmvmoYdGrEpjV/rshuVQeR59kTv07R/UQiaxLMMGN7FggwuMm+/t8UJO22V9d8GGW
 eEnkzepLgEZaETzuigkJGGq0/5UuFTbKkWoQfDoFc/kPFoB+Tgh8+fBuM/G+NiYtuPoEWCxUOa
 KTWd6/m8Gb3XAakl6u8gmcQiv2JKtu9JN53bel926R8Vb+GHQJyi/ZVLPgvjyFvJCmhD/9tgCv
 LEc=
Date: Tue, 28 Apr 2020 23:33:53 +0000
From: Joseph Myers <joseph@codesourcery.com>
X-X-Sender: jsm28@digraph.polyomino.org.uk
To: Simon Marchi <simon.marchi@efficios.com>
CC: <libc-alpha@sourceware.org>
Subject: Re: [PATCH] Makeconfig: Use $(error ...) to output error message
In-Reply-To: <20200428222024.3266407-1-simon.marchi@efficios.com>
Message-ID: <alpine.DEB.2.21.2004282333340.21260@digraph.polyomino.org.uk>
References: <20200428222024.3266407-1-simon.marchi@efficios.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
X-Originating-IP: [137.202.0.90]
X-ClientProxiedBy: SVR-IES-MBX-07.mgc.mentorg.com (139.181.222.7) To
 svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1)
X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,
 HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=no autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Apr 2020 23:34:01 -0000

On Tue, 28 Apr 2020, Simon Marchi via Libc-alpha wrote:

> Being not familiar with the glibc repository, I typed "make" inside some
> subdirectory that has a Makefile, and was met with:
> 
>     $ make
>     ../Makeconfig:42: *** missing separator.  Stop.
> 
> At Makeconfig:42, we have:
> 
>     objdir must be defined by the build-directory Makefile.
> 
> Change that to use $(error ...), which I guess was the original
> intention.  The result is:

This patch is OK.

-- 
Joseph S. Myers
joseph@codesourcery.com