From: Joseph Myers <joseph@codesourcery.com>
To: Martin Sebor <msebor@gmail.com>
Cc: DJ Delorie <dj@redhat.com>, <libc-alpha@sourceware.org>
Subject: Re: [PATCH] improve out-of-bounds checking with GCC 10 attribute access [BZ #25219]
Date: Wed, 6 May 2020 22:27:36 +0000 [thread overview]
Message-ID: <alpine.DEB.2.21.2005062223230.18350@digraph.polyomino.org.uk> (raw)
In-Reply-To: <7b066bcc-0757-1dee-4a45-0f630a389715@gmail.com>
On Wed, 6 May 2020, Martin Sebor wrote:
> I can look into suppressing the new ones. What's the usual way of
> doing that in Glibc tests?
We typically use the DIAG_* macros from libc-diag.h, with appropriate
comments justifying the use in a particular case. Warnings may be ignored
for the whole file (e.g. string/tester.c) or locally for particular code.
Note that the GCC version number in DIAG_IGNORE_NEEDS_COMMENT is for the
most recent GCC version known to produce the warning (it's an indicator of
which DIAG_* calls might be appropriate to review for whether they are
still needed). While if the warning in question isn't supported in GCC 6,
appropriate __GNUC_PREREQ version conditionals are needed around the
DIAG_IGNORE_NEEDS_COMMENT call to avoid errors about an unknown option
when building with older GCC.
--
Joseph S. Myers
joseph@codesourcery.com
prev parent reply other threads:[~2020-05-06 22:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-30 22:12 Martin Sebor
2020-04-30 22:37 ` Dmitry V. Levin
2020-05-01 2:42 ` DJ Delorie
2020-05-01 19:54 ` Martin Sebor
2020-05-01 22:02 ` DJ Delorie
2020-05-04 17:34 ` Martin Sebor
2020-05-04 18:40 ` Martin Sebor
2020-05-06 20:44 ` Joseph Myers
2020-05-06 21:08 ` DJ Delorie
2020-05-06 22:09 ` Martin Sebor
2020-05-06 22:27 ` Joseph Myers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2005062223230.18350@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=dj@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=msebor@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).