From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa3.mentor.iphmx.com (esa3.mentor.iphmx.com [68.232.137.180]) by sourceware.org (Postfix) with ESMTPS id E3E823851C24; Wed, 24 Jun 2020 17:43:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E3E823851C24 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=joseph_myers@mentor.com IronPort-SDR: 9zV/UZnkccQfWAB7kFGUqFL+ewdIFvulsH7ldFOpChui1KKMAZHrZNSL+Qc1W2kub+lViNIkCG rE1Mkll5O4V2XPR4Q2ykcfEPPXyMOvQb3N+urg9dug6T/dwf189csYG7eP+Nfle6gsFz4U5j6V HzOMHrHknS0+aoOX94vRgzIaZ41jtWT4/Gn6fjY6JgGQ8zhxFlfyZr0J8bCqe9k8B1Al38g8MQ QYONqO2akRvZLd+i6U6epD8+bN5csEOkmizQVCT89vW809hFs18Wu02v7Qf3mf2B1h998Bayp6 P04= X-IronPort-AV: E=Sophos;i="5.75,276,1589270400"; d="scan'208";a="50158624" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa3.mentor.iphmx.com with ESMTP; 24 Jun 2020 09:43:31 -0800 IronPort-SDR: bx5wFFv0hfz0OsmvdimKYSjMSIKANvHOSmqTxK5dp1jlVPobk3t8HShiY0vAUdJ1wROMhfMJuO MTll47U8lsLssAUbxtL/YFkOb59cOn3k/0LSw7VUFWTB4VUMfKuEuDns+zgVjF1eIFwp2+z8GY j++CmEximlpj/L4/UOJjBDKHf4XZLHrzgfUue3ZmwwJR/Tpgs4P97fYddhK5y/UzowAvxM9ric nJU94k27v5o2hVtB7kiD4A/xkHEgSHLgN2pFFXc+2iTZWSNBAgvNtMfcte1uy169Mez2IeL7tO fYk= Date: Wed, 24 Jun 2020 17:43:25 +0000 From: Joseph Myers X-X-Sender: jsm28@digraph.polyomino.org.uk To: Lukasz Majewski CC: Florian Weimer , GNU C Library , Andreas Schwab , , Alistair Francis Subject: Re: [Y2038] Replacement of struct timespec with struct __timespec64 in glibc internal code In-Reply-To: <20200624142603.3bb82862@jawa> Message-ID: References: <20200601140740.16371-1-lukma@denx.de> <20200603145347.4025892b@jawa> <20200624142603.3bb82862@jawa> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: SVR-IES-MBX-08.mgc.mentorg.com (139.181.222.8) To SVR-IES-MBX-03.mgc.mentorg.com (139.181.222.3) X-Spam-Status: No, score=-3130.1 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Jun 2020 17:43:34 -0000 On Wed, 24 Jun 2020, Lukasz Majewski wrote: > > Also, tests can't generally > > use 64-bit time interfaces from libc until _TIME_BITS=64 support is > > actually implemented. > > Does it mean that tests - like sysdeps/pthread/tst-mutex5.c - will > always use exported struct timespec? (aliased to 64 bit struct > __timespec64 when needed)? Yes. Tests normally use public interfaces, not internal ones. Where a test needs to use internal interfaces related to time, such interfaces may end up needing variants for different sizes of time_t (but unless they actually result in functions defined in installed shared libraries and used both from those shared libraries and from other installed libraries or executables, the hidden_def mechanism is not relevant for such interfaces). -- Joseph S. Myers joseph@codesourcery.com