From: Joseph Myers <joseph@codesourcery.com>
To: Lukasz Majewski <lukma@denx.de>
Cc: Andreas Schwab <schwab@suse.de>,
Florian Weimer <fweimer@redhat.com>,
GNU C Library <libc-alpha@sourceware.org>,
<libc-help@sourceware.org>,
Alistair Francis <alistair.francis@wdc.com>
Subject: Re: [Y2038] Replacement of struct timespec with struct __timespec64 in glibc internal code
Date: Wed, 24 Jun 2020 22:10:25 +0000 [thread overview]
Message-ID: <alpine.DEB.2.21.2006242207100.28946@digraph.polyomino.org.uk> (raw)
In-Reply-To: <20200624223951.46056c9c@jawa>
On Wed, 24 Jun 2020, Lukasz Majewski wrote:
> > The functions in support/timespec-*.c should probably be renamed to
> > xtimespec_*.
>
> And the 'x' prefix means that those functions are supposed to be used
> for testing?
The 'x' prefix is in the style of xmalloc as used in many GNU packages -
checking for errors in a safer way than the default libc API.
Most of the 'x' functions are thereby unsuitable for use in library code,
but may be used in tests and in code that goes into the various
executables shipped with glibc, because they exit the program on error and
library code should generally not do that. (The 'x' names are also not in
the implementation namespace; non-static internal functions used within
library code need to have reserved names such as __*.)
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2020-06-24 22:10 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-01 14:07 [RFC 00/12] [RFC] y2038: Convert timespec_{sub|add|create} in support to be Y2038 safe Lukasz Majewski
2020-06-01 14:07 ` [RFC 01/12] doc: Fix wording and formattine in ./support/README Lukasz Majewski
2020-06-01 14:07 ` [RFC 02/12] y2038: Rename timespec_compare to __timespec_compare Lukasz Majewski
2020-06-01 14:07 ` [RFC 03/12] y2038: Rename make_timespec to __make_timespec Lukasz Majewski
2020-06-01 14:07 ` [RFC 04/12] y2038: Rename xclock_gettime to __xclock_gettime Lukasz Majewski
2020-06-01 14:07 ` [RFC 05/12] y2038: Rename xclock_now to __xclock_now Lukasz Majewski
2020-06-01 14:07 ` [RFC 06/12] y2038: Rename timespec_sub to __timespec_sub Lukasz Majewski
2020-06-01 14:07 ` [RFC 07/12] y2038: Rename timespec_add to __timespec_add Lukasz Majewski
2020-06-01 14:07 ` [RFC 08/12] y2038: Convert __make_timespec to be Y2038 safe Lukasz Majewski
2020-06-01 14:07 ` [RFC 09/12] y2038: Convert __xclock_gettime " Lukasz Majewski
2020-06-01 14:07 ` [RFC 10/12] y2038: Convert __xclock_now " Lukasz Majewski
2020-06-01 14:07 ` [RFC 11/12] y2038: Convert timespec* files in ./support " Lukasz Majewski
2020-06-01 14:07 ` [RFC 12/12] y2038: Convert timespec_* from posix-timer.h " Lukasz Majewski
2020-06-02 18:05 ` [RFC 00/12] [RFC] y2038: Convert timespec_{sub|add|create} in support " Joseph Myers
2020-06-03 11:42 ` Lukasz Majewski
2020-06-03 12:53 ` [Y2038] Replacement of struct timespec with struct __timespec64 in glibc internal code Lukasz Majewski
2020-06-03 17:28 ` Joseph Myers
2020-06-03 20:45 ` Lukasz Majewski
2020-06-24 12:26 ` Lukasz Majewski
2020-06-24 12:43 ` Andreas Schwab
2020-06-24 20:39 ` Lukasz Majewski
2020-06-24 22:10 ` Joseph Myers [this message]
2020-06-24 17:43 ` Joseph Myers
2020-06-08 22:23 ` Samuel Thibault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2006242207100.28946@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=alistair.francis@wdc.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=libc-help@sourceware.org \
--cc=lukma@denx.de \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).