From: Joseph Myers <joseph@codesourcery.com>
To: DJ Delorie <dj@redhat.com>
Cc: "Martin Liška" <mliska@suse.cz>,
schwab@linux-m68k.org, fw@deneb.enyo.de,
libc-alpha@sourceware.org
Subject: Re: [PATCH] Use size_t for mallinfo fields.
Date: Tue, 1 Sep 2020 17:26:11 +0000 [thread overview]
Message-ID: <alpine.DEB.2.21.2009011721061.6258@digraph.polyomino.org.uk> (raw)
In-Reply-To: <xnv9h2d20r.fsf@greed.delorie.com>
There are several key pieces missing from the mallinfo2 commit.
* mallinfo2 is not added to GLIBC_2.33 in malloc/Versions. So it's not
exported from shared glibc, so it can't actually be used at all.
* Once a function is exported from shared libc, all the ABI test baselines
need updating accordingly.
* Any new function needs a testcase added to the testsuite. If there were
such a test, it would have shown up the first problem of the function not
being exported (that's why there should be tests even for e.g. syscall
wrappers for syscalls that don't do anything useful as non-root - simply
testing that it's possible to compile and link a call to each public
function is useful).
* Any new function should be mentioned as a new feature in the NEWS file.
* Any deprecation should be listed under "Deprecated and removed features,
and other changes affecting compatibility:" in the NEWS file.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2020-09-01 17:26 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 12:00 Martin Liška
2020-07-07 12:17 ` Andreas Schwab
2020-07-07 13:07 ` Martin Liška
2020-07-07 13:19 ` H.J. Lu
2020-07-07 13:49 ` Florian Weimer
2020-07-07 13:52 ` Martin Liška
2020-07-07 14:22 ` Florian Weimer
2020-07-07 14:32 ` Andreas Schwab
2020-07-07 14:36 ` Florian Weimer
2020-07-08 7:25 ` Martin Liška
2020-07-08 7:24 ` Martin Liška
2020-07-23 10:23 ` Martin Liška
2020-07-23 14:38 ` Szabolcs Nagy
2020-07-27 12:08 ` Martin Liška
2020-07-27 12:21 ` Florian Weimer
2020-07-27 12:45 ` Martin Liška
2020-08-11 12:26 ` Martin Liška
2020-08-11 13:44 ` Florian Weimer
2020-08-11 17:08 ` DJ Delorie
2020-08-12 12:29 ` Martin Liška
2020-08-24 9:55 ` Martin Liška
2020-08-28 19:05 ` DJ Delorie
2020-08-31 13:35 ` H.J. Lu
2020-08-31 13:56 ` Adhemerval Zanella
2020-08-31 14:00 ` H.J. Lu
2020-08-31 14:10 ` Adhemerval Zanella
2020-09-01 17:26 ` Joseph Myers [this message]
2020-09-02 13:19 ` Martin Liška
2020-09-02 13:34 ` Adhemerval Zanella
2020-09-02 14:00 ` Carlos O'Donell
2020-09-02 16:11 ` DJ Delorie
2020-09-21 8:49 ` Martin Liška
2020-09-02 20:16 ` DJ Delorie
2020-09-02 20:24 ` Florian Weimer
2020-09-02 21:04 ` [PATCH/v2] " DJ Delorie
2020-09-03 11:17 ` Adhemerval Zanella
2020-09-03 21:33 ` DJ Delorie
2020-09-17 23:02 ` DJ Delorie
2020-09-02 20:25 ` [PATCH] " Joseph Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2009011721061.6258@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=dj@redhat.com \
--cc=fw@deneb.enyo.de \
--cc=libc-alpha@sourceware.org \
--cc=mliska@suse.cz \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).