From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa4.mentor.iphmx.com (esa4.mentor.iphmx.com [68.232.137.252]) by sourceware.org (Postfix) with ESMTPS id 2C7693870890 for ; Tue, 1 Sep 2020 17:26:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 2C7693870890 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=joseph_myers@mentor.com IronPort-SDR: gY0J3gEc89A8H9E3Hi7OYpo7Z/O1j1IApq+a2HNkgW8TdzaVc+aURUbrA7LIjg7Kcqll6Aym18 YW2VejyWoXhSCBJrFEmj4s60FiPXRGB+Oi2O9LA+G5vvWW7SmNc12XAXNwd3Ta1fBXqdboFU2o xVszfquMIqzrHQrBrJ5kNXBHFzDMM5NBeLEFUYVudKnCLBCt6VvKUCz4vNWjAyqI22xGMQINDM Ih8SXM469GKbNgkx8x2iNHs/cYyrn6lLGfEgrPkmn/vvk2YPP4SDTBjnqNxfvtOfLfb85lMrwI rJ0= X-IronPort-AV: E=Sophos;i="5.76,379,1592899200"; d="scan'208";a="52598157" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa4.mentor.iphmx.com with ESMTP; 01 Sep 2020 09:26:17 -0800 IronPort-SDR: Fhzhd+oqwXpk0pU1jYPzssUMeEKuYLryIru5MEW8yiZHmYY7aolrQapdpqaWQb4Y5CnQcJmFHx x8MUB7WgIAp0xstwd/PtEv/Delg/VXHuVfHbowD/h8nqPfilMtZiD5WyXVELMQtrNgZS1gxP8L baCVcwtREQbSvcUvyRNf/quNhpjlhbil52vxoMgQ2UlJBFQkOua7YunOuz1OTK6v8P7s7bMPXr uG2mEMNhiTKQUuyDHWZCe3YtjD2lD/wi1meqnroWmTrnzgkLWpoaehHIqH42lwCIfNU1hMxWSy ZtY= Date: Tue, 1 Sep 2020 17:26:11 +0000 From: Joseph Myers X-X-Sender: jsm28@digraph.polyomino.org.uk To: DJ Delorie CC: =?ISO-8859-15?Q?Martin_Li=A8ka?= , , , Subject: Re: [PATCH] Use size_t for mallinfo fields. In-Reply-To: Message-ID: References: User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: SVR-IES-MBX-03.mgc.mentorg.com (139.181.222.3) To SVR-IES-MBX-03.mgc.mentorg.com (139.181.222.3) X-Spam-Status: No, score=-3127.6 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Sep 2020 17:26:20 -0000 There are several key pieces missing from the mallinfo2 commit. * mallinfo2 is not added to GLIBC_2.33 in malloc/Versions. So it's not exported from shared glibc, so it can't actually be used at all. * Once a function is exported from shared libc, all the ABI test baselines need updating accordingly. * Any new function needs a testcase added to the testsuite. If there were such a test, it would have shown up the first problem of the function not being exported (that's why there should be tests even for e.g. syscall wrappers for syscalls that don't do anything useful as non-root - simply testing that it's possible to compile and link a call to each public function is useful). * Any new function should be mentioned as a new feature in the NEWS file. * Any deprecation should be listed under "Deprecated and removed features, and other changes affecting compatibility:" in the NEWS file. -- Joseph S. Myers joseph@codesourcery.com