From: Joseph Myers <joseph@codesourcery.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: <libc-alpha@sourceware.org>
Subject: Re: [PATCH] sysconf: Add _SC_MINSIGSTKSZ/_SC_SIGSTKSZ [BZ #20305]
Date: Mon, 12 Oct 2020 22:03:57 +0000 [thread overview]
Message-ID: <alpine.DEB.2.21.2010122201030.4518@digraph.polyomino.org.uk> (raw)
In-Reply-To: <20201010121935.3263605-1-hjl.tools@gmail.com>
On Sat, 10 Oct 2020, H.J. Lu via Libc-alpha wrote:
> +* Add _SC_MINSIGSTKSZ and _SC_SIGSTKSZ. When _SC_SIGSTKSZ_SOURCE is
> + defined, MINSIGSTKSZ and SIGSTKSZ are no longer constant on Linux.
> + MINSIGSTKSZ is redefined to sysconf(_SC_MINSIGSTKSZ) and SIGSTKSZ
> + is redefined to sysconf (_SC_SIGSTKSZ).
I don't think the _SC_SIGSTKSZ_SOURCE option is a good idea. But in any
case, all feature test macros need to be documented in creature.texi, and
the new _SC_* constants would need documenting in conf.texi, with
appropriate documentation that they are GNU extensions.
> +#ifdef __USE_SC_SIGSTKSZ
And the internal macros for new feature test macros ought to be tested via
__GLIBC_USE (thus, always defined to either 0 or 1) rather than #ifdef.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2020-10-12 22:04 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-10 12:19 H.J. Lu
2020-10-12 7:53 ` Szabolcs Nagy
2020-10-12 11:04 ` Dave Martin
2020-10-12 12:42 ` V4 " H.J. Lu
2020-10-12 13:21 ` Dave Martin
2020-10-12 14:12 ` Szabolcs Nagy
2020-10-12 14:37 ` Dave Martin
2020-10-12 15:36 ` [libc-coord] " Rich Felker
2020-10-12 22:03 ` Joseph Myers [this message]
2020-10-13 20:32 ` V5 " H.J. Lu
2020-10-14 17:47 ` Dave Martin
2020-10-14 18:07 ` Florian Weimer
2020-10-19 16:30 ` Dave Martin
2020-10-15 11:57 ` V6 " H.J. Lu
2020-10-19 15:08 ` Dave Martin
2020-10-19 21:32 ` H.J. Lu
2020-10-20 9:19 ` Dave Martin
2020-10-20 14:59 ` H.J. Lu
2020-10-20 15:22 ` Dave Martin
2020-10-20 18:19 ` V7 " H.J. Lu
2020-11-03 3:06 ` PING: " H.J. Lu
2020-11-04 16:50 ` Dave Martin
2020-11-04 17:48 ` H.J. Lu
2020-11-18 14:13 ` H.J. Lu
2020-11-18 14:25 ` Zack Weinberg
2020-11-18 14:40 ` H.J. Lu
2020-11-18 15:12 ` Zack Weinberg
2020-11-18 15:17 ` H.J. Lu
2020-11-18 15:20 ` Florian Weimer
2020-11-18 17:04 ` Dave Martin
2020-11-18 17:35 ` Florian Weimer
2020-11-18 17:48 ` H.J. Lu
2020-11-18 18:09 ` Dave Martin
2020-11-19 14:59 ` Szabolcs Nagy
2020-11-19 15:10 ` H.J. Lu
2020-11-19 15:39 ` Zack Weinberg
2020-11-19 15:51 ` Florian Weimer
2020-11-19 16:16 ` Rich Felker
2020-11-19 16:52 ` Dave Martin
2020-11-19 16:37 ` Dave Martin
2020-11-19 17:29 ` Rich Felker
2020-11-19 17:33 ` Szabolcs Nagy
2020-11-19 19:39 ` Dave Martin
2020-11-20 14:08 ` H.J. Lu
2020-11-20 14:11 ` Florian Weimer
2020-11-20 23:13 ` V8 " H.J. Lu
2021-01-20 14:16 ` Carlos O'Donell
2021-01-20 15:05 ` V9 " H.J. Lu
2021-01-22 19:41 ` V10 " H.J. Lu
2021-01-25 13:31 ` Carlos O'Donell
2021-01-25 13:57 ` H.J. Lu
2021-01-25 13:59 ` Carlos O'Donell
2021-01-25 13:58 ` Carlos O'Donell
2021-01-25 14:16 ` Florian Weimer
2021-02-02 13:08 ` Carlos O'Donell
2021-01-25 14:34 ` Carlos O'Donell
2021-01-20 15:06 ` V8 " Florian Weimer
2021-01-20 15:30 ` Carlos O'Donell
2021-01-20 15:33 ` H.J. Lu
2021-01-20 15:59 ` Carlos O'Donell
2021-01-20 16:04 ` H.J. Lu
2021-01-20 15:33 ` Florian Weimer
2020-10-15 12:26 ` [PATCH] Deprecate SIGSTKSZ/MINSIGSTKSZ with _SC_SIGSTKSZ_SOURCE H.J. Lu
2020-10-15 19:59 ` Joseph Myers
2020-10-15 21:22 ` V2 " H.J. Lu
2020-10-16 0:57 ` Joseph Myers
2021-07-09 18:53 ` Carlos O'Donell
2021-07-09 19:34 ` H.J. Lu
2020-10-12 22:07 ` [PATCH] sysconf: Add _SC_MINSIGSTKSZ/_SC_SIGSTKSZ [BZ #20305] Joseph Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2010122201030.4518@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=hjl.tools@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).