From: Joseph Myers <joseph@codesourcery.com>
To: Lukasz Majewski <lukma@denx.de>
Cc: Adhemerval Zanella <adhemerval.zanella@linaro.org>,
Florian Weimer <fweimer@redhat.com>,
GNU C Library <libc-alpha@sourceware.org>,
Andreas Schwab <schwab@suse.de>,
Stepan Golosunov <stepan@golosunov.pp.ru>,
Alistair Francis <alistair.francis@wdc.com>
Subject: Re: [PATCH] y2038: Reorder placement of st_ino in struct __stat64_t64
Date: Thu, 15 Oct 2020 13:04:44 +0000 [thread overview]
Message-ID: <alpine.DEB.2.21.2010151302120.18330@digraph.polyomino.org.uk> (raw)
In-Reply-To: <20201015115826.109c4844@jawa>
On Thu, 15 Oct 2020, Lukasz Majewski wrote:
> Wouldn't it be better to just make struct __stat64_t64 exported in e.g.
> sysdeps/unix/sysv/linux/bits/struct_stat_time64.h and then just make
> an alias in exported struct_stat.h
> (sysdeps/unix/sysv/linux/bits/struct_stat.h):
>
> #ifdef __USE_TIME_BITS64
> #include <bits/struct_stat_time64.h>
> #define stat __stat64_t64
I don't think redirecting struct tags with #define like that is safe, at
least not when the tag is also used as a function name as here.
--
Joseph S. Myers
joseph@codesourcery.com
prev parent reply other threads:[~2020-10-15 13:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-14 13:00 Lukasz Majewski
2020-10-14 13:13 ` Adhemerval Zanella
2020-10-14 14:14 ` Lukasz Majewski
2020-10-14 14:21 ` Andreas Schwab
2020-10-14 15:33 ` Lukasz Majewski
2020-10-15 10:28 ` Andreas Schwab
2020-10-14 14:23 ` Adhemerval Zanella
2020-10-14 15:56 ` Lukasz Majewski
2020-10-14 17:50 ` Adhemerval Zanella
2020-10-14 22:00 ` Lukasz Majewski
2020-10-15 11:03 ` Adhemerval Zanella
2020-10-15 11:21 ` Lukasz Majewski
2020-10-14 21:37 ` Joseph Myers
2020-10-15 9:58 ` Lukasz Majewski
2020-10-15 13:04 ` Joseph Myers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2010151302120.18330@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=adhemerval.zanella@linaro.org \
--cc=alistair.francis@wdc.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=lukma@denx.de \
--cc=schwab@suse.de \
--cc=stepan@golosunov.pp.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).