From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from angie.orcam.me.uk (angie.orcam.me.uk [IPv6:2001:4190:8020::4]) by sourceware.org (Postfix) with ESMTP id BADC13858C27 for ; Thu, 1 Apr 2021 00:07:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org BADC13858C27 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=orcam.me.uk Authentication-Results: sourceware.org; spf=none smtp.mailfrom=macro@orcam.me.uk Received: by angie.orcam.me.uk (Postfix, from userid 500) id 66AF092009C; Thu, 1 Apr 2021 02:07:20 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by angie.orcam.me.uk (Postfix) with ESMTP id 6293A92009B; Thu, 1 Apr 2021 02:07:20 +0200 (CEST) Date: Thu, 1 Apr 2021 02:07:20 +0200 (CEST) From: "Maciej W. Rozycki" To: Adhemerval Zanella cc: libc-alpha@sourceware.org Subject: Re: [PATCH 3/5] linux: Use statx for MIPSn64 In-Reply-To: <20210319183121.2252064-4-adhemerval.zanella@linaro.org> Message-ID: References: <20210319183121.2252064-1-adhemerval.zanella@linaro.org> <20210319183121.2252064-4-adhemerval.zanella@linaro.org> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-3494.3 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, KAM_INFOUSMEBIZ, KAM_LAZY_DOMAIN_SECURITY, KAM_NUMSUBJECT, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Apr 2021 00:07:23 -0000 On Fri, 19 Mar 2021, Adhemerval Zanella via Libc-alpha wrote: > diff --git a/sysdeps/unix/sysv/linux/fstatat64.c b/sysdeps/unix/sysv/linux/fstatat64.c > index c3a030af58..b9b8cd994b 100644 > --- a/sysdeps/unix/sysv/linux/fstatat64.c > +++ b/sysdeps/unix/sysv/linux/fstatat64.c > @@ -117,7 +137,8 @@ fstatat64_time64_stat (int fd, const char *file, struct __stat64_t64 *buf, > } > > #if (__WORDSIZE == 32 \ > - && (!defined __SYSCALL_WORDSIZE || __SYSCALL_WORDSIZE == 32)) > + && (!defined __SYSCALL_WORDSIZE || __SYSCALL_WORDSIZE == 32)) \ > + || defined STAT_HAS_TIME32 Weird indentation here (which made me wonder how the ordering between && and || has been resolved so that GCC does not complain before I realised it's simply misindented parenthesisation). Only caught as I saw the GIT commit message though. Maciej