From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from angie.orcam.me.uk (angie.orcam.me.uk [IPv6:2001:4190:8020::4]) by sourceware.org (Postfix) with ESMTP id 0A0953857814 for ; Thu, 1 Apr 2021 18:00:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 0A0953857814 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=orcam.me.uk Authentication-Results: sourceware.org; spf=none smtp.mailfrom=macro@orcam.me.uk Received: by angie.orcam.me.uk (Postfix, from userid 500) id 77B9E92009C; Thu, 1 Apr 2021 20:00:48 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by angie.orcam.me.uk (Postfix) with ESMTP id 6963992009B; Thu, 1 Apr 2021 20:00:48 +0200 (CEST) Date: Thu, 1 Apr 2021 20:00:48 +0200 (CEST) From: "Maciej W. Rozycki" To: Adhemerval Zanella cc: libc-alpha@sourceware.org Subject: Re: [PATCH 3/5] linux: Use statx for MIPSn64 In-Reply-To: Message-ID: References: <20210319183121.2252064-1-adhemerval.zanella@linaro.org> <20210319183121.2252064-4-adhemerval.zanella@linaro.org> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-3494.4 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, KAM_INFOUSMEBIZ, KAM_LAZY_DOMAIN_SECURITY, KAM_NUMSUBJECT, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Apr 2021 18:00:50 -0000 On Thu, 1 Apr 2021, Adhemerval Zanella via Libc-alpha wrote: > > Weird indentation here (which made me wonder how the ordering between && > > and || has been resolved so that GCC does not complain before I realised > > it's simply misindented parenthesisation). Only caught as I saw the GIT > > commit message though. > > The preprocessor indentation is confusing sometimes, but I think it should > adjusted only slight to follow other usages: > > diff --git a/sysdeps/unix/sysv/linux/fstatat64.c b/sysdeps/unix/sysv/linux/fstatat64.c > index f968e4ef05..ab25f64187 100644 > --- a/sysdeps/unix/sysv/linux/fstatat64.c > +++ b/sysdeps/unix/sysv/linux/fstatat64.c > @@ -137,7 +137,7 @@ fstatat64_time64_stat (int fd, const char *file, struct __stat64_t64 *buf, > > #if (__WORDSIZE == 32 \ > && (!defined __SYSCALL_WORDSIZE || __SYSCALL_WORDSIZE == 32)) \ > - || defined STAT_HAS_TIME32 > + || defined STAT_HAS_TIME32 > # define FSTATAT_USE_STATX 1 > #else > > Am I missing something here? No, that's what I meant. While using outer parentheses seems to be what the GNU Coding Standards suggest for Emacs to indent properly, but I'm no Emacs user and we have cases with preprocessor statements missing those, and otherwise there is no indentation ambiguity here, so I guess this will be OK with your amendment above. Maciej