From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=SD/f=BI=orcam.me.uk=macro@sourceware.org>
Received: from angie.orcam.me.uk (angie.orcam.me.uk [78.133.224.34])
	by sourceware.org (Postfix) with ESMTP id AEFC0385700F
	for <libc-alpha@sourceware.org>; Fri, 19 May 2023 11:21:29 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AEFC0385700F
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=orcam.me.uk
Authentication-Results: sourceware.org; spf=none smtp.mailfrom=orcam.me.uk
Received: by angie.orcam.me.uk (Postfix, from userid 500)
	id 36B0892009D; Fri, 19 May 2023 13:21:29 +0200 (CEST)
Received: from localhost (localhost [127.0.0.1])
	by angie.orcam.me.uk (Postfix) with ESMTP id 2FAD992009B;
	Fri, 19 May 2023 12:21:29 +0100 (BST)
Date: Fri, 19 May 2023 12:21:29 +0100 (BST)
From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: Florian Weimer <fweimer@redhat.com>
cc: Ying Huang <ying.huang@oss.cipunited.com>, libc-alpha@sourceware.org, 
    yunqiang.su@oss.cipunited.com
Subject: Re: [PATCH v2] MIPS: Sync elf.h from binutils
In-Reply-To: <87v8gs6a3l.fsf@oldenburg.str.redhat.com>
Message-ID: <alpine.DEB.2.21.2305190550110.50034@angie.orcam.me.uk>
References: <20230516061449.192954-1-ying.huang@oss.cipunited.com> <87v8gs6a3l.fsf@oldenburg.str.redhat.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
X-Spam-Status: No, score=-1163.3 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,KAM_INFOUSMEBIZ,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <libc-alpha.sourceware.org>

On Tue, 16 May 2023, Florian Weimer via Libc-alpha wrote:

> > +/* Object attribute values.  */
> > +enum
> > +{
> > +  /* Values defined for Tag_GNU_MIPS_ABI_MSA.  */
> > +
> > +  /* Not tagged or not using any ABIs affected by the differences.  */
> > +  Val_GNU_MIPS_ABI_MSA_ANY = 0,
> > +
> > +  /* Using 128-bit MSA.  */
> > +  Val_GNU_MIPS_ABI_MSA_128 = 1,
> > +};
> 
> Any reason for using enum constants here, and not #define?  I understand
> there is other MIPS precedent, but why continue in this direction?

 AFAICT all architectures use enumeration constants for object attributes, 
with the exception of TI C6X which seems to have special requirements.  I 
don't know what the actual original rationale has been, but it does help a 
lot with debugging.

  Maciej