From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=Tsb+=B2=orcam.me.uk=macro@sourceware.org>
Received: from angie.orcam.me.uk (angie.orcam.me.uk [IPv6:2001:4190:8020::34])
	by sourceware.org (Postfix) with ESMTP id F070E3858D33
	for <libc-alpha@sourceware.org>; Tue,  6 Jun 2023 16:26:08 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F070E3858D33
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=orcam.me.uk
Authentication-Results: sourceware.org; spf=none smtp.mailfrom=orcam.me.uk
Received: by angie.orcam.me.uk (Postfix, from userid 500)
	id 27DB292009C; Tue,  6 Jun 2023 18:26:08 +0200 (CEST)
Received: from localhost (localhost [127.0.0.1])
	by angie.orcam.me.uk (Postfix) with ESMTP id 2210F92009B;
	Tue,  6 Jun 2023 17:26:08 +0100 (BST)
Date: Tue, 6 Jun 2023 17:26:08 +0100 (BST)
From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: Ying Huang <ying.huang@oss.cipunited.com>
cc: libc-alpha@sourceware.org, yunqiang.su@oss.cipunited.com
Subject: Re: [PATCH v4] MIPS: Sync elf.h from binutils
In-Reply-To: <48c20c02-3f77-2340-dcd0-80dd3f301512@oss.cipunited.com>
Message-ID: <alpine.DEB.2.21.2306060830080.36323@angie.orcam.me.uk>
References: <20230602080745.241502-1-ying.huang@oss.cipunited.com> <alpine.DEB.2.21.2306040036090.36323@angie.orcam.me.uk> <48c20c02-3f77-2340-dcd0-80dd3f301512@oss.cipunited.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
X-Spam-Status: No, score=-3488.8 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,KAM_INFOUSMEBIZ,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <libc-alpha.sourceware.org>

Hi Ying,

> OK. And I have a question, can I use space+tab combination when aligned?

 If you mean a sequence of one or more of spaces immediately followed by 
one or more tabs, than this is not allowed by the GNU Coding Standards.

> Because when I only use tab to align, it occurs:
> 
> Vim open file shows alignment, but git diff show not alignment.

 Note that the leading plus/minus/space character in a unidiff will affect 
how columns are aligned where tabs are used and is sometimes a cause for 
confusion, especially when hand-editing patches.  Just ignore that.  It's 
the formatting of the actual file that matters.

 NB I have:

core.whitespace=indent-with-non-tab,space-before-tab,trailing-space

set in my git configuration for GNU toolchain repos, which helps identify 
some of these issues.  You may still have to double-check your result, as 
these automatic checks are not completely fool-proof.

 HTH,

  Maciej