From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=GSaJ=NH=orcam.me.uk=macro@sourceware.org>
Received: from angie.orcam.me.uk (angie.orcam.me.uk [IPv6:2001:4190:8020::34])
	by sourceware.org (Postfix) with ESMTP id 364F8380C6F5
	for <libc-alpha@sourceware.org>; Wed,  5 Jun 2024 15:15:55 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 364F8380C6F5
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=orcam.me.uk
Authentication-Results: sourceware.org; spf=none smtp.mailfrom=orcam.me.uk
ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 364F8380C6F5
Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:4190:8020::34
ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1717600557; cv=none;
	b=UrHk5F4WbkwHqBKkAR5Pkv4mvpvg9guybOFSuZi58xq7j6rktRIz6ER1sefB2yftIZZ7v5po73bFkx/wm/gyqiOwBXL+kV6qZfJ16dSdQEcfZgfHPxDLVqoGKeJh1un2jtAXVfNYUeXTo1zdAtwbv3xDRJ2RBLVTtOarR6E5HOw=
ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key;
	t=1717600557; c=relaxed/simple;
	bh=PGeReP5BOMjxC9clkPYmEx9WjwbpJ46L9O4A3sLY58g=;
	h=Date:From:To:Subject:Message-ID:MIME-Version; b=H6mnBrE7GQy5k5k/2pAOm1MxwBNw0b3k8jDPbfdqj869dcbXpBjGAQSSuyBRKORnfR/PCSfmBsJWd609k5FKNY2qXKwy86eBO2JWJmjMnv0Gzo08GWBasN+GtHLdLcnkLIF+w4diKx5CljuqnOgv7NQsUiXxEKSiXEK9ZY/FnbM=
ARC-Authentication-Results: i=1; server2.sourceware.org
Received: by angie.orcam.me.uk (Postfix, from userid 500)
	id 3BCF992009C; Wed,  5 Jun 2024 17:15:54 +0200 (CEST)
Received: from localhost (localhost [127.0.0.1])
	by angie.orcam.me.uk (Postfix) with ESMTP id 3577A92009B;
	Wed,  5 Jun 2024 16:15:54 +0100 (BST)
Date: Wed, 5 Jun 2024 16:15:54 +0100 (BST)
From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
cc: YunQiang Su <syq@debian.org>, libc-alpha@sourceware.org, 
    YunQiang Su <syq@gcc.gnu.org>
Subject: Re: [PATCH v3] MIPSr6/math: Use builtin fma and fmaf
In-Reply-To: <3f878318-5afb-45cf-b85e-ff21df14aa20@linaro.org>
Message-ID: <alpine.DEB.2.21.2406050251100.9248@angie.orcam.me.uk>
References: <20240604013119.79086-1-syq@debian.org> <3f878318-5afb-45cf-b85e-ff21df14aa20@linaro.org>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
X-Spam-Status: No, score=-3487.2 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,KAM_INFOUSMEBIZ,KAM_LAZY_DOMAIN_SECURITY,KAM_LINKBAIT,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <libc-alpha.sourceware.org>

On Tue, 4 Jun 2024, Adhemerval Zanella Netto wrote:

> > MIPSr6 has MADDF.s/MADDF.d instructions, which are fused.
> > 
> > In MIPS ISA, double support can be subsetted.  Only FMAF is enabled
> > for this case.
> > 
> > 	* sysdeps/mips/fpu/math-use-builtins-fma.h
> > 
> > Signed-off-by: YunQiang Su <syq@gcc.gnu.org>
> 
> LGTM, thanks.
> 
> Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>

 Doesn't this need a copyright notice?

  Maciej