From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=wUty=N2=orcam.me.uk=macro@sourceware.org>
Received: from angie.orcam.me.uk (angie.orcam.me.uk [IPv6:2001:4190:8020::34])
	by sourceware.org (Postfix) with ESMTP id ECB84384AB52
	for <libc-alpha@sourceware.org>; Mon, 24 Jun 2024 22:55:41 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org ECB84384AB52
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=orcam.me.uk
Authentication-Results: sourceware.org; spf=none smtp.mailfrom=orcam.me.uk
ARC-Filter: OpenARC Filter v1.0.0 sourceware.org ECB84384AB52
Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:4190:8020::34
ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1719269743; cv=none;
	b=nc96ts0yrba4hYeEsLfjAZ5GhwDUJW1flbKx/P7CxVBKpF9RbMeb24K30kj7r/yrfWScoZEW/bRvRe7rx7d2OqDIoxfKHeGadzIQZMJmDXxUrfRxVt3KTBKb6U/7rIzr3Iupf3b2Bpb3nkvcGyM4MYUgdVXQCNifOrb411r2qRE=
ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key;
	t=1719269743; c=relaxed/simple;
	bh=Y1FgwBbZ2K7xo/qD8gfhA1+EWgrlPhfPoZNv2EV+3+0=;
	h=Date:From:To:Subject:Message-ID:MIME-Version; b=XHFwfbbTULZGj37Es4eCFDT5CUtWSEGXTc22cIVklHOcgajIp4hcsQYHqdwYJtPT0wG1Q+5r8izXDWzfuDLqtil+8w1pqFh6aBk6xaNymIOrCjhld9hpGLCcGkeZ8JPVzFVNvZ94mWi8Kio3FF/uWb0eo+zyry7I5iEFzTpg5rw=
ARC-Authentication-Results: i=1; server2.sourceware.org
Received: by angie.orcam.me.uk (Postfix, from userid 500)
	id 5877392009C; Tue, 25 Jun 2024 00:55:41 +0200 (CEST)
Received: from localhost (localhost [127.0.0.1])
	by angie.orcam.me.uk (Postfix) with ESMTP id 52DBE92009B;
	Mon, 24 Jun 2024 23:55:41 +0100 (BST)
Date: Mon, 24 Jun 2024 23:55:41 +0100 (BST)
From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: =?UTF-8?Q?Andreas_K=2E_H=C3=BCttel?= <dilfridge@gentoo.org>
cc: libc-alpha@sourceware.org, YunQiang Su <syq@gcc.gnu.org>, 
    Adhemerval Zanella <adhemerval.zanella@linaro.org>, 
    =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>
Subject: Re: [COMMITTED] MIPSr6/math: Use builtin fma and fmaf
In-Reply-To: <20240624174605.17406-1-dilfridge@gentoo.org>
Message-ID: <alpine.DEB.2.21.2406242349540.43454@angie.orcam.me.uk>
References: <20240624174605.17406-1-dilfridge@gentoo.org>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
X-Spam-Status: No, score=-3488.3 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,KAM_INFOUSMEBIZ,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <libc-alpha.sourceware.org>

On Mon, 24 Jun 2024, Andreas K. Hüttel wrote:

> From: YunQiang Su <syq@gcc.gnu.org>
> 
> MIPSr6 has MADDF.s/MADDF.d instructions, which are fused.
> 
> In MIPS ISA, double support can be subsetted.  Only FMAF is enabled
> for this case.
> 
> 	* sysdeps/mips/fpu/math-use-builtins-fma.h
> 
> Signed-off-by: YunQiang Su <syq@gcc.gnu.org>
> Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

 It seems odd to me to commit an obsolete change reported to cause actual 
compilation errors as well as raising copyright notice concerns where 3 
subsequent revisions have been already posted that addressed these issues.

  Maciej