Re: [RFC 0/6] y2038: Prepare glibc to be Y2038 safe for 32 bit ports

[Joseph Myers <joseph@codesourcery.com>]

On Sat, 5 Dec 2020, Lukasz Majewski wrote:

> This patch series is the RFC for preparing glibc to be Y2038 safe on
> ports with __WORDSIZE=32 && __TIMESIZE!=64 (e.g. 32 bit ARM).

What exactly does "preparing" mean here?

I'd expect support for _TIME_BITS to go along with public symbol versions 
for all the new symbols that functions get redirected to, because 
otherwise people building with _TIME_BITS=64 will get either link failures 
or broken binaries depending on GLIBC_PRIVATE symbols.  But as far as I 
can see, this patch series only adds GLIBC_PRIVATE symbols, not any public 
symbols or corresponding abilist updates.

I'd also expect support for _TIME_BITS to go along with tests covering all 
the new interfaces (that is, for every time-affected interface, there 
should be a test that it works properly with _TIME_BITS=64, typically a 
test that defines _TIME_BITS to 64 then includes an existing test for that 
interface, possibly with other tests to verify that large time values work 
properly where possible).

You don't say how this series was tested, but this may be around the point 
where build-many-glibcs.py testing is needed.  Certainly any patch in such 
a series that adds a new public symbol should be tested with 
build-many-glibcs.py to make sure that all the ABI test baseline updates 
are correct.

-- 
Joseph S. Myers
joseph@codesourcery.com