From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa4.mentor.iphmx.com (esa4.mentor.iphmx.com [68.232.137.252]) by sourceware.org (Postfix) with ESMTPS id A59B53857003 for ; Wed, 9 Dec 2020 00:07:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A59B53857003 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=joseph_myers@mentor.com IronPort-SDR: Kx3CzNRDrp3GFGg0yRhfksLFRutV/kzqCz0L6MyTqyppAzpJPqEapRrxMWxzfxnWTjU6R1ApgH 5ny7b7LYzDSfJk8JAb6iW4ba8jgW9ui3KD7fx1wF4WTit4JXl8gVPsZy6V0plJx+TGm7vLUDcX g2nE846hSfAhO7rxYcE8ptfssiWIlo04ho+iQLUMh4+LOiurBs/ecqMMGKMJ4oUuprUMnuk6s/ bNHox6hy34VDrmPPZ2ZN9Fpf6QRbwQyrR4zvXDVKOdeIZ/2PMuBu/TOo+dVZnuLpfJTKi5w8T0 eVc= X-IronPort-AV: E=Sophos;i="5.78,404,1599552000"; d="scan'208";a="56091760" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa4.mentor.iphmx.com with ESMTP; 08 Dec 2020 16:07:29 -0800 IronPort-SDR: x0HjkoaZxKXDXqmT87mS50o4Zfx5rDgzJNGxz1+WbVXDZZiDEV5a6KuPqNmRZPi6n9Fqbv0UJc OgbtizDNNtLOw3/8ImdI8IO6EqI0xMLtmKmlAkdTQ+WtMyrVjv0ToTNig9BrLozAmOUgSdvvmW SkmKhtGUBAXcSYVDgy3BdMk55q7DN3yzmrFO2GXwGfmgSas0rpInH0SjFzWtqPpmrnywGWynJR ceUx9s53O633/+lJ+k6K67g/wyPnj0gKEl1SAFIhNZpRFYWWRekf5ctoKPZdUDGmFGfRRLezdy zRk= Date: Wed, 9 Dec 2020 00:07:24 +0000 From: Joseph Myers X-X-Sender: jsm28@digraph.polyomino.org.uk To: Martin Sebor CC: GNU C Library Subject: Re: [PATCH] add support for -Wmismatched-dealloc In-Reply-To: Message-ID: References: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: SVR-IES-MBX-04.mgc.mentorg.com (139.181.222.4) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-Spam-Status: No, score=-3124.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Dec 2020 00:07:32 -0000 I don't see any definition of __attr_dealloc (presumably should be a macro in misc/sys/cdefs.h) in this patch (or in the glibc source tree). Given all the functions in stdio.h with the same list of deallocation functions, there should probably be another macro there to expand to __attribute_malloc__ __attr_dealloc (fclose, 1) __attr_dealloc (freopen, 3) __attr_dealloc_freopen64. (That would also apply to open_wmemstream in wchar.h, but I suppose you have the issue there with functions not being declared in wchar.h, only in stdio.h?) -- Joseph S. Myers joseph@codesourcery.com