From: Joseph Myers <joseph@codesourcery.com>
To: Siddhesh Poyarekar <siddhesh@gotplt.org>
Cc: Siddhesh Poyarekar <siddhesh@sourceware.org>,
<libc-alpha@sourceware.org>, <fweimer@redhat.com>
Subject: Re: [PING][PATCH 2/2] Limit unnormal tests to supported long double formats
Date: Tue, 12 Jan 2021 18:21:57 +0000 [thread overview]
Message-ID: <alpine.DEB.2.22.394.2101121817170.1193382@digraph.polyomino.org.uk> (raw)
In-Reply-To: <6c3bfca8-1801-ed53-ef51-cb0fcab21903@gotplt.org>
On Tue, 12 Jan 2021, Siddhesh Poyarekar wrote:
> On 1/4/21 7:54 PM, Siddhesh Poyarekar via Libc-alpha wrote:
> > Use the right argument code (j) in the unnormal tests and prevent
> > compilation of the tests in anything other than long double and
> > Float64x. Additionally, cast inputs from the
> > ieee_long_double_shape_type struct to Float64x to properly test it.
I don't see how TEST_COND_unnormal makes sense here. When would it ever
have a different value from TEST_COND_intel96? TEST_UNNORMAL seems
redundant since TEST_COND_intel96 should always be false anyway except for
cases where long double or _Float64x is being tested.
If ia64 processors handle some of these representations differently from
x86 processors (something best checked on hardware) then there might need
to be different conditionals for that, depending on whether some, all or
none of these tests describe semantics that correspond to how ia64
hardware handles these representations. But that would involve some sort
of architecture-specific macro definition, not one in the headers for
particular types being tested.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2021-01-12 18:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-04 14:24 [PATCH 0/2] unnormal test case fixes Siddhesh Poyarekar
2021-01-04 14:24 ` [PATCH 1/2] Drop nan-pseudo-number.h usage from tests Siddhesh Poyarekar
2021-01-04 14:29 ` Florian Weimer
2021-01-04 14:37 ` Siddhesh Poyarekar
2021-01-04 15:13 ` Szabolcs Nagy
2021-01-04 15:21 ` Siddhesh Poyarekar
2021-01-04 15:17 ` Florian Weimer
2021-01-04 15:21 ` Siddhesh Poyarekar
2021-01-04 14:24 ` [PATCH 2/2] Limit unnormal tests to supported long double formats Siddhesh Poyarekar
2021-01-12 7:22 ` [PING][PATCH " Siddhesh Poyarekar
2021-01-12 18:21 ` Joseph Myers [this message]
2021-01-13 4:38 ` [PATCH v2] Use the right argument code in unnormal tests Siddhesh Poyarekar
2021-01-13 17:41 ` Joseph Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2101121817170.1193382@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=siddhesh@gotplt.org \
--cc=siddhesh@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).