From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa3.mentor.iphmx.com (esa3.mentor.iphmx.com [68.232.137.180]) by sourceware.org (Postfix) with ESMTPS id D09A13971C1A for ; Mon, 25 Jan 2021 22:27:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D09A13971C1A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=joseph_myers@mentor.com IronPort-SDR: 3cP32aDOltfasOEZpGHO+oB4Bpkn+uF8QHV5c9iyShiuHnbkSuMeeSbNAm3dhpoQZcfar4Cnw4 bkRHEJEgsej3KzJ23QRIPWjLdvyS5swmLtn/ytoxDbOV6K3OirHudfGZBSUjExy7kjD1C3vFk6 kX/HHV+VyIZES1P1zFNBYanX9U87no0o2OzQZSQ4/ontFRXvnpZ+j/3jVufbz3FR2Gt+7IO2Pb zW5QAY+aPzr8Qw9P5D/ORVPsNEeP3pVwn0SJNTsUvpEkgIsiNPsj2gKk3ycWz/sY0SXjt8NiCD c3Y= X-IronPort-AV: E=Sophos;i="5.79,374,1602576000"; d="scan'208";a="57412557" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa3.mentor.iphmx.com with ESMTP; 25 Jan 2021 14:26:59 -0800 IronPort-SDR: 7r3H7S5MtKDphuvZtrMprzL8UJoT97LFLbekK1IB8psP8qXwaDtJXRJsk1OVczd3zf57kc0x34 skMY+r3H5WA3VN4RmghDlY5gOTq8mI86mBf7VSx+8yTgWtpQGstEtNS8yrycyImXQw/28cpLRj Fs9b/+mLfnMDojnY6+nJuUZdK7Bkr+upF7dm9JNhejN2kCJQRnLqqVXH5cZkL1RR1yiEOV78EN E7L/cx253XBDcbt0fWy3gLSTWApv9hq1kNtPBgKE+JYOhT1jmvvzbEMQ57XYxOexY6+E0pbzgV dcA= Date: Mon, 25 Jan 2021 22:26:53 +0000 From: Joseph Myers X-X-Sender: jsm28@digraph.polyomino.org.uk To: Lukasz Majewski CC: Adhemerval Zanella , Florian Weimer , GNU C Library , Florian Weimer , Alistair Francis Subject: Re: [PATCH] tst: Provide Y2038 tests for mktime (tst-mktime4.c) In-Reply-To: <20210125223150.692ec27b@jawa> Message-ID: References: <20210125130308.32242-1-lukma@denx.de> <20210125223150.692ec27b@jawa> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-Spam-Status: No, score=-3123.8 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Jan 2021 22:27:02 -0000 On Mon, 25 Jan 2021, Lukasz Majewski wrote: > 1. On 32 bit ports - check correct operation of mktime for 32 bit > time_t. If those checks fail, then we fail the test. But if those checks pass, the test will end with UNSUPPORTED rather than PASS. If there is anything useful to verify on 32-bit ports, the test should end with PASS if that verification succeeds and FAIL if that verification fails - not with a choice of UNSUPPORTED and FAIL. -- Joseph S. Myers joseph@codesourcery.com