From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa1.mentor.iphmx.com (esa1.mentor.iphmx.com [68.232.129.153]) by sourceware.org (Postfix) with ESMTPS id 8746B384A01D for ; Sat, 6 Mar 2021 00:14:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8746B384A01D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=joseph_myers@mentor.com IronPort-SDR: NRKLlpgIpQQr6wRpxRMjmaXinorGWl9fknwjy0eV7oK8MKYGBWD4milt00WiAzwVZ2/BKLufbF K6m5BMBcdW5qjH2h+bw7ApGB1+LUM+zjbMRQCC383H12+pYmR+umSzdcJDvLw0vUotJjWgT5uc TsQHdkm741WjyAVTcP/6K+q4eirwWUbI77Yhxi/QhuR2OOarrEtxvV1D30VAiCS4qrp0+7tm49 9fockLI/PQLOkbMIrXyajRVcKpMQBnz5dUq5H0mhHyXCPs3IEWkyN8oZ3nioDa2ZYbqAFsAkgd OV4= X-IronPort-AV: E=Sophos;i="5.81,226,1610438400"; d="scan'208";a="61148655" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa1.mentor.iphmx.com with ESMTP; 05 Mar 2021 16:13:59 -0800 IronPort-SDR: Q4Oju48b2elgRDN4UcZ+4KUEyImnnXBIFaTWUglY+oBtIR8J4m4NbJ5gdBWNm0EHKQ+KDELE+G 7xeKCT/8JEu5B019/733OsAibLoC5CIsv8dRUV7ltsF0uDuQfAfzpFNWPXQQhj+GfU/qhdHe4a hwBdVfgwOFKGIYdG0ToilwqjNeKa265q+7SfyzNPueW4KkuLuS3T5dFGnks4nGb7OQB3cG9hN9 9CCbQQn+mo777JrmlEhgr6NudLixRUJFEv3OhSFFtdRetWacaF93bglZbmDThN8SQY2YApqIug RK8= Date: Sat, 6 Mar 2021 00:13:54 +0000 From: Joseph Myers X-X-Sender: jsm28@digraph.polyomino.org.uk To: Adhemerval Zanella CC: Subject: Re: [PATCH 44/52] y2038: Add test coverage In-Reply-To: <20210305201518.798584-45-adhemerval.zanella@linaro.org> Message-ID: References: <20210305201518.798584-1-adhemerval.zanella@linaro.org> <20210305201518.798584-45-adhemerval.zanella@linaro.org> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: SVR-IES-MBX-03.mgc.mentorg.com (139.181.222.3) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-Spam-Status: No, score=-3122.8 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Mar 2021 00:14:01 -0000 On Fri, 5 Mar 2021, Adhemerval Zanella via Libc-alpha wrote: > It is enabled through a new rule, tests-y2038, which is built only > when the ABI supports the comapt 64-bit time_t (defined by the > header time64-compat.h, which also enables the creation of the > symbol Version for Linux). It means the tests are not built > for ABI which already provide default 64-bit time_t. I'm not convinced it's correct not to build them for ABIs that already have 64-bit time_t. _TIME_BITS=64 should work, and do nothing, for such ABIs; it seems useful to build and run the tests to verify that the headers don't have any incorrect redirections in that case, for example. (On the other hand, if any systems - Hurd? - don't get support for 64-bit time, it's correct not to build the tests for such systems.) -- Joseph S. Myers joseph@codesourcery.com