From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa2.mentor.iphmx.com (esa2.mentor.iphmx.com [68.232.141.98]) by sourceware.org (Postfix) with ESMTPS id 15C923857829 for ; Wed, 17 Mar 2021 21:01:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 15C923857829 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=joseph_myers@mentor.com IronPort-SDR: TM2gA4KFCDtnb3wtlFOl8c5dm42zXpfOnArZ6icKcO1jyXl6LhRbb4H3Lvpr88j29I1bkevnBA odRtJR5cq9mS4ixnLArABCuG2N+nmEZ7ajpES1sIUtxQLCXa4nxhR25mLYKhiSfNPZf//IKm91 gtDfgNJhZUy3u80gjEwI4NB5Wa/MBvKLkT/DPOHUaItAlaZK2LlegbuF8P2u0yWwRlQFSww6ij 6sGYmLCzGO8hssGmy3/YSNWe1k7pDKIWiJGP815MKV2HmyoBb9QuHCP8z9IY/BrFq1frQL51PZ bWo= X-IronPort-AV: E=Sophos;i="5.81,257,1610438400"; d="scan'208";a="59200452" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa2.mentor.iphmx.com with ESMTP; 17 Mar 2021 13:01:13 -0800 IronPort-SDR: dyVFU/TnFRX0tx6Hgjk1I0dj9+L4G0nhAS/nC4/eJA+/NtLKJohBNqjWVSiNATc7K0GK+D6rdc zW3mr+0qtERUtzEDJrLX3Ys4FmQzyTNl9b9vARw6p52fJwpPlTPlQVcRLrT0Me3bEWY/0PmzkR vSeKplVO1jpjPh520KBhpIfV78RI3e9LrjQmoYMmFb8VPdLSvga6cwMWafmbj69V3JQJqqHe3E tb7cXxGhE1Tm8V1z9Uj6ZLBbHxad2ekwhew8ZkEaVFVs5KPvnujYZJKwr5YXW2ytuC0w2Lhc4C kjk= Date: Wed, 17 Mar 2021 21:01:08 +0000 From: Joseph Myers X-X-Sender: jsm28@digraph.polyomino.org.uk To: Stefan Liebler CC: Subject: Re: [PATCH] S390: Don't test nanoseconds in io/tst-stat.c In-Reply-To: <20210317130352.1782897-1-stli@linux.ibm.com> Message-ID: References: <20210317130352.1782897-1-stli@linux.ibm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: SVR-IES-MBX-07.mgc.mentorg.com (139.181.222.7) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-Spam-Status: No, score=-3122.6 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Mar 2021 21:01:15 -0000 On Wed, 17 Mar 2021, Stefan Liebler via Libc-alpha wrote: > Both new tests io/tst-stat and io/tst-stat-lfs (_FILE_OFFSET_BITS=64) > are comparing the nanosecond fields with the statx result. Unfortunately > on s390(31bit) those fields are always zero if old KABI with non-LFS > support is used. With _FILE_OFFSET_BITS=64 stat is using statx internally. My understanding is that, if using a kernel that supports statx, this disabling is not needed. If so, we want to be sure to remove this disabling once we can assume a kernel supporting statx (on s390). The way we ensure that is having a conditional on __ASSUME_STATX in the code in question so that it's immediately visible when we remove __ASSUME_STATX that this disabling can be removed from the glibc source code as well. -- Joseph S. Myers joseph@codesourcery.com