From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa2.mentor.iphmx.com (esa2.mentor.iphmx.com [68.232.141.98]) by sourceware.org (Postfix) with ESMTPS id 5EF7B3857022 for ; Tue, 27 Apr 2021 21:58:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5EF7B3857022 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=joseph_myers@mentor.com IronPort-SDR: Tz8IAHhJzj2457sNNEGwzOwk1Doj8wapq3pcWwNWRYXNI4ihq6KLGXzy5oVo+B62tKjMBQqEZj kJVGiUxKXXnVfiv4Mh3qlIQi+/jWAKrQ3LhItI+NPcHai87HhBjCb2X9CWsUv177aKoYA91qpd gzNofqoW+DyhosgKk9GV7nUpBmNQJtMyoBSmxwP6UG31U2Q66OElvaIEEyshB7eFxpX9RtpVQG tOhwa6o7d2cdxC2IPQSNCD0aN5flyzoknTs7R0G/6gqvF/NJOaVytqSM+O/LE0ukHs2NAnQsoP 1B8= X-IronPort-AV: E=Sophos;i="5.82,256,1613462400"; d="scan'208";a="60570921" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa2.mentor.iphmx.com with ESMTP; 27 Apr 2021 13:58:49 -0800 IronPort-SDR: 1m4epCagKpjPd2zAaBoPRtxnyt2t0r5MA0ktm1WRG6uM4dtw7AeobWy0l9RYvGWJEJ62YecS8T w+crEDVOfFMwECtlxF+YlI5V+WlQ777FnxecwJZhWBhotrL2+UE85tl8ZzDd1uO6w5Vxb0/fs1 EiVmVpLhdXIrDKbQTNF5ayDOsMosLBg2CnW2xa8YbLSKJqcZfl0xZExAJ+3kHWfYbZhVqMK5EA L/PtjtFhs4bFfudWOw16C3K3DjvJqlW+78Rd4CUbOTiDtnB7gu4jxWq4EW2EO3OApwIb2oj0FX sMo= Date: Tue, 27 Apr 2021 21:58:44 +0000 From: Joseph Myers X-X-Sender: jsm28@digraph.polyomino.org.uk To: Martin Sebor CC: Florian Weimer , Martin Sebor via Libc-alpha Subject: Re: [PATCH] add attribute none to pthread_setspecific (BZ #27714) In-Reply-To: <571eb466-8979-8579-3b52-38f29a628a39@gmail.com> Message-ID: References: <2ec7fadb-cc15-a005-f708-d2adecc8cc39@gmail.com> <875z08qqy8.fsf@oldenburg.str.redhat.com> <571eb466-8979-8579-3b52-38f29a628a39@gmail.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-05.mgc.mentorg.com (139.181.222.5) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-Spam-Status: No, score=-3121.8 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8BIT X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Apr 2021 21:58:51 -0000 On Tue, 27 Apr 2021, Martin Sebor via Libc-alpha wrote: > These are warnings in my build (I've seen a few others scroll by > and have always assumed they were expected(*)). Those you pasted Most warnings are errors by default (unless you use --disable-werror, which should never normally be used in glibc development unless you're e.g. reviewing the warnings you get if you add extra warning options to those with which glibc is built by default, in order to fix those warnings before adding the extra options). > I test by simply running make check. I can make the change to > the test if you expect warning-free test builds. We expect builds, for all glibc ABIs, free from compile errors or failures of tests that can run without needing to execute any code for the glibc architecture. That means no warnings that are turned into errors by -Werror. There are some warnings for which -Wno-error or pragmas are used to stop them being errors; all other warnings are disallowed. > [*] Here's an example of a warning I just noticed while rerunning > make check: > > tst-chk1.c: In function ‘do_test’: That's an example covered by -Wno-error. # We know these tests have problems with format strings, this is what # we are testing. Disable that warning. They are also testing # deprecated functions (notably gets) so disable that warning as well. # And they also generate warnings from warning attributes, which # cannot be disabled via pragmas, so require -Wno-error to be used. CFLAGS-tst-chk1.c += -Wno-format -Wno-deprecated-declarations -Wno-error (Any code disabling any warnings or disabling -Werror for them is expected to have a comment explaining why it's OK to do so in that case.) -- Joseph S. Myers joseph@codesourcery.com