public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
* sysdeps/generic/libc.abilist and __libc_single_threaded
@ 2021-05-13 20:51 Joseph Myers
  2021-05-13 21:09 ` Florian Weimer
  0 siblings, 1 reply; 2+ messages in thread
From: Joseph Myers @ 2021-05-13 20:51 UTC (permalink / raw)
  To: libc-alpha

sysdeps/generic/libc.abilist is nonempty: it contains only the symbol 
__libc_single_threaded, added by:

commit 706ad1e7af37be1d25fc2359bda006d31fe0d11b
Author: Florian Weimer <fweimer@redhat.com>
Date:   Wed May 20 15:40:35 2020 +0200

    Add the __libc_single_threaded variable

Should this file really contain this symbol, or should it be an empty file 
like all the other sysdeps/generic/*.abilist, given that all glibc ABIs 
need their own libc.abilist for libc ABI tests to pass?

-- 
Joseph S. Myers
joseph@codesourcery.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: sysdeps/generic/libc.abilist and __libc_single_threaded
  2021-05-13 20:51 sysdeps/generic/libc.abilist and __libc_single_threaded Joseph Myers
@ 2021-05-13 21:09 ` Florian Weimer
  0 siblings, 0 replies; 2+ messages in thread
From: Florian Weimer @ 2021-05-13 21:09 UTC (permalink / raw)
  To: Joseph Myers; +Cc: libc-alpha

* Joseph Myers:

> sysdeps/generic/libc.abilist is nonempty: it contains only the symbol 
> __libc_single_threaded, added by:
>
> commit 706ad1e7af37be1d25fc2359bda006d31fe0d11b
> Author: Florian Weimer <fweimer@redhat.com>
> Date:   Wed May 20 15:40:35 2020 +0200
>
>     Add the __libc_single_threaded variable
>
> Should this file really contain this symbol, or should it be an empty file 
> like all the other sysdeps/generic/*.abilist, given that all glibc ABIs 
> need their own libc.abilist for libc ABI tests to pass?

This was a mistake, sorry about that.  Apparently I used a custom script
to edit the abilist files, presumably to resolve some conflict.  We
should remove the entry.  (The generic update script already excludes
*/generic*.)

Florian


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-05-13 21:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-13 20:51 sysdeps/generic/libc.abilist and __libc_single_threaded Joseph Myers
2021-05-13 21:09 ` Florian Weimer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).