From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <joseph_myers@mentor.com>
Received: from esa3.mentor.iphmx.com (esa3.mentor.iphmx.com [68.232.137.180])
 by sourceware.org (Postfix) with ESMTPS id 7F45F3898525
 for <libc-alpha@sourceware.org>; Wed, 19 May 2021 15:37:33 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7F45F3898525
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none)
 header.from=codesourcery.com
Authentication-Results: sourceware.org;
 spf=pass smtp.mailfrom=joseph_myers@mentor.com
IronPort-SDR: A8nj+bZ66p2UeQ3+qVv83/gTe8jKuLRnTpXI03xUaYGMusobxYbVui4o5x7He7LxDzNUY724Mr
 bCz9IZh34Ya21UnPxciAjuhtsLqHMTe3+tt1xFeDLy/nGkLlY1dcuqNVb+J6yhTjGCZcr3hr6x
 7tcHPuVlGeuneL8uVazLBxU051kuemuR2fnBM6mQCmPhHkrW6MboWFCbcMKD4xqgvK9l4eT1AF
 jsiYOqYbjSDXZFjLFXXcJOdgWCrObE4bvUOYSTJDRaTLlpHh6udVXIH3YgYt4a3Dyhzyh8+ysv
 qG0=
X-IronPort-AV: E=Sophos;i="5.82,313,1613462400"; d="scan'208";a="61392297"
Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165])
 by esa3.mentor.iphmx.com with ESMTP; 19 May 2021 07:37:32 -0800
IronPort-SDR: Kb/dEI1UpDFYVtkE9EfnvEhMI826p7qUcImndSuUAhD4d/F3CIWs0AoytSiqY2P2GTYYwczwsF
 4P/DNm8Fzxy9WDIioI9+ls2h5exOso/kqeblHjHIqtQ8fgGZPknFuN0MtsEPaY2HnWhCV8+mGX
 PNTDRpERFNZ7shsl4Tpqc2sMcvW+4vZbJ3f9ugPOJhacGkBoEPmr8woAXkXyeO5B/MahhBKxsj
 SB4mkA48i1DKNi1MGdnOMXJdFPvoiNwxFOhBRugumCIU8WvRRbtV8bDn9X3bsXvgQmkq8Zlp3J
 gqU=
Date: Wed, 19 May 2021 15:37:27 +0000
From: Joseph Myers <joseph@codesourcery.com>
X-X-Sender: jsm28@digraph.polyomino.org.uk
To: Jonathan Wakely <jwakely@redhat.com>
CC: <libc-alpha@sourceware.org>
Subject: Re: [PATCH] Suppress -Wcast-qual warnings in bsearch
In-Reply-To: <YKUdWuzFbiAnWx+Y@redhat.com>
Message-ID: <alpine.DEB.2.22.394.2105191535500.14970@digraph.polyomino.org.uk>
References: <YKUdWuzFbiAnWx+Y@redhat.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
X-Originating-IP: [137.202.0.90]
X-ClientProxiedBy: svr-ies-mbx-05.mgc.mentorg.com (139.181.222.5) To
 svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1)
X-Spam-Status: No, score=-3121.2 required=5.0 tests=BAYES_00,
 HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS,
 TXREP autolearn=no autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 19 May 2021 15:37:35 -0000

On Wed, 19 May 2021, Jonathan Wakely via Libc-alpha wrote:

> +#pragma GCC diagnostic push
> +#pragma GCC diagnostic ignored "-Wcast-qual"
>  	return (void *) __p;
> +#pragma GCC diagnostic pop

I think such pragma uses in installed headers should be conditional on 
__GNUC_PREREQ (4, 6) (either directly or via conditionally defining a 
macro in sys/cdefs.h).

-- 
Joseph S. Myers
joseph@codesourcery.com