From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa1.mentor.iphmx.com (esa1.mentor.iphmx.com [68.232.129.153]) by sourceware.org (Postfix) with ESMTPS id 22E7E3857C77 for ; Thu, 27 May 2021 16:36:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 22E7E3857C77 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=joseph_myers@mentor.com IronPort-SDR: OHA4Xh/2zOrD3muHVGBSzhCkFKFdEGEsUqZWGlyK+39+8cppex2+ZLHYNLuJsI6duIxiAa6wqM cqqgrj2AT/+ZwbvWzWGqzWtI1cy5QlxcpSzn77S+1hZ5MgHKkhETO02pBRXZ8lccD6woMrvx+3 ySWoAcz9xV4FMQyLTTQSY8h7rli3cYCQjyj9Kw6kN+a7bIPNP4Pa4I64DJ+IRSHWA1O+SUBMPj Y4FPDw9BeM3EDRj5CRQQX29UcaiQItUcCi0YCibyciXACo9mSr5U+JG4HSKIGCdN1zdg3iy5e5 yVU= X-IronPort-AV: E=Sophos;i="5.83,227,1616486400"; d="scan'208";a="64145381" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa1.mentor.iphmx.com with ESMTP; 27 May 2021 08:36:11 -0800 IronPort-SDR: bFVoyF16FI6wr/F92xSn8apFI8V0QkEkFUZWpiaDnVvvQb3vy0uvVDe71zxQlgBl2T7Ft27f9n CRYA8QQwispou4iQ6Vx9jhR0u0eistEtZuYqI9bXESTj7uNn1f7e/SIePsac5AZ088xY7E7aGz qtx6cgf+D/9oSpmOCoPeibQwbuDvs7GoaaJhtVSYmsJRgyczje22TK1UAwWSadydzzpF3YiyUQ iebiv4HA0cutC6f9T4Sb7TzEemlkYW+44LS7JJXGY4HHOrfvlwMgk3MOVh+PwalF2+9qc31GKH 2tA= Date: Thu, 27 May 2021 16:36:06 +0000 From: Joseph Myers X-X-Sender: jsm28@digraph.polyomino.org.uk To: Fergus Dall CC: , Mike Frysinger , clumptini , Subject: Re: [PATCH v2 2/2] rtld: Add tests for new --no-default-paths option In-Reply-To: Message-ID: References: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-05.mgc.mentorg.com (139.181.222.5) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-Spam-Status: No, score=-3121.0 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 May 2021 16:36:13 -0000 On Thu, 27 May 2021, Fergus Dall via Libc-alpha wrote: > +const char libc[] = "/libc.so.6"; > +const char libdl[] = "/libdl.so.2"; If these are meant to be the SONAMEs of libc and libdl (with "/" prepended), you should use LIBC_SO and LIBDL_SO from . Some configurations have different SONAMEs (look for libc= and libdl= in shlib-versions files). Also watch out for any interaction with Florian's patches to move libdl into libc. > + strcpy(lib_src, support_slibdir_prefix); Throughout this patch, there should be a space before '(' in function calls; tests should follow GNU style, like other glibc code. (In the GCC and GDB testsuites, it's useful to have code with a range of different styles, to make sure those tools work well with such code, but that doesn't apply to the glibc testsuite.) > +const char libc[] = "/libc.so.6"; > +const char libdl[] = "/libdl.so.2"; Same comment about using applies here. > +int main(int argc, char *argv[]) { > + if (argc < 2) { > + FAIL_EXIT1(usage); > + } Again, GNU style fixes. Return type on its own line, space before '(', open braces on their own lines (and indented from the "if"). -- Joseph S. Myers joseph@codesourcery.com