From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa4.mentor.iphmx.com (esa4.mentor.iphmx.com [68.232.137.252]) by sourceware.org (Postfix) with ESMTPS id 43C2939730F1 for ; Wed, 2 Jun 2021 18:20:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 43C2939730F1 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com IronPort-SDR: IzJEEmuSzGdlJyY9FNBBK01EAu8np5363bNAHw2vF6CDdYqZ7QPMHl1nIkbkKpFHrKY/Dc+DXV pAFbkgto4YV58Zbw6Hpf1Y6mNfnEpoaR7RoMmUodaDXH0kSkh4rr/F2KVYSjHxGTtVMkDt24Ut n+l8HTrp9jg0cjU3b3UcbbwgCVVw/G1CTafSn6TuK471eFPQdBZ43oOm2b9hEOHaE9zfeKnA8E FXFvnuZg7sbI7kskKg35Zoq9s4qP31jsrQjpFkPMuhg92LhOUCJWwsdESTpWtDsevo3NMSAU66 kD8= X-IronPort-AV: E=Sophos;i="5.83,242,1616486400"; d="scan'208";a="62084596" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa4.mentor.iphmx.com with ESMTP; 02 Jun 2021 10:20:20 -0800 IronPort-SDR: iI+Cw8GjCLU0/shYa2Jk+ohG4YzYnG48GR7G/Vyi3Y5Fa8DyngjXq/HgXzuZqdsRkfp0kVeCah +dXjbU56YoEgBwQL0vndbpxsO+E8RiFXJhqYARB8x5QjovV3U8py+SrenBPSSXRSkpk1MgzYr6 gJa+eX25Rbh7AKa4CwkqyYcRfCUKkeOcwGgNaJ5VV4oMTcv7Yc38sNXrWYIImXNTk504IyNkG1 eP2FmL5FRFRb8dJ1IGgyVHiz2xp8srJJB4XhYW6pHqphQon35Esa2BzKzaXoTgSUICsGFEeg6M ch0= Date: Wed, 2 Jun 2021 18:20:14 +0000 From: Joseph Myers X-X-Sender: jsm28@digraph.polyomino.org.uk To: Andreas Schwab CC: Adhemerval Zanella , Adhemerval Zanella via Libc-alpha Subject: Re: [PATCH v3] nptl: Deallocate the thread stack on setup failure (BZ #19511) In-Reply-To: <87im2wjr6f.fsf@igel.home> Message-ID: References: <20210527172823.3461314-3-adhemerval.zanella@linaro.org> <20210602125644.3725112-1-adhemerval.zanella@linaro.org> <87r1hkjtwj.fsf@igel.home> <4e623fa1-419e-5c54-2da3-61a2c3f143ed@linaro.org> <87mts8jsda.fsf@igel.home> <28311d99-55b0-808f-5130-1a9895b9cf77@linaro.org> <87im2wjr6f.fsf@igel.home> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-09.mgc.mentorg.com (139.181.222.9) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-Spam-Status: No, score=-3120.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Jun 2021 18:20:22 -0000 On Wed, 2 Jun 2021, Andreas Schwab wrote: > On Jun 02 2021, Adhemerval Zanella wrote: > > > I don't have a strong preference here, maybe use a 'bool' then? > > bool has architecture dependent size. bool is one byte for all configurations supported by glibc (the only configuration supported by GCC for which it isn't is powerpc-darwin). Although I don't see any likely reason for glibc code to depend on it being one byte. (GCC 2.95 had a different, four-byte bool in ; if any future glibc interfaces involve bool in ABIs, I expect we should simply not support use of those interfaces with GCC 2.95.) -- Joseph S. Myers joseph@codesourcery.com