From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa4.mentor.iphmx.com (esa4.mentor.iphmx.com [68.232.137.252]) by sourceware.org (Postfix) with ESMTPS id 24899389683E for ; Mon, 7 Jun 2021 18:53:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 24899389683E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com IronPort-SDR: d3QVFgCwBpn+JD2sOl06uV/pVCHmVG5EjkQZOf1LpLomsOY/W4+2ZEQ8Z1VYkM24i0kh53Ex8e N1LlF3awGxx3vY0w4xxAmq/JuKxxnnYw+1KPhrrqAlOuS3RUdzB1gMRVZC2fc1+e4CNJ2sSGIJ 6JkHVTTwZslslE/euIf09EMBupXwG4icDpAiyUgVsixJzjnTLFJ2TJXS5toUkC4h3h7r/wr1oW KBRHb3JcN3HOgdTOO2BnzUm7/S2DUPeKyhmgwSwP4e6toAwuIwyDCNRvj7NuhWt4DPFngTLnO3 xpg= X-IronPort-AV: E=Sophos;i="5.83,255,1616486400"; d="scan'208";a="62256790" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa4.mentor.iphmx.com with ESMTP; 07 Jun 2021 10:53:51 -0800 IronPort-SDR: xM/61CeQeNlA21+niyGzITXUrz3ZWiz2q4PgiIJkdOSwB4PI4PSL8MEQGmiKx1y2iWJbPB4RP7 HVk97hU/l/weaRWEGBtSHx/Txn+zDo74arH2+K/luF7MQK741CZTXgnKBF1uLw1xTSdo0CmWLX L93kYXqPsu2i/J+PDK2e4mUTLT7bBlaK+y0gPVb6dATCmSEeeZ2txAx5H+w42jz9H57rWCcpwg gyHLZ5Pzo2CJ/vkxrYIlbdap4AFIcQtPkmUUD0Lqzxr6Hk9OSiiNRThil7IaxeEpVkKjqg7q/f ZNk= Date: Mon, 7 Jun 2021 18:53:46 +0000 From: Joseph Myers X-X-Sender: jsm28@digraph.polyomino.org.uk To: Tom Honermann CC: libc-alpha Subject: Re: [PATCH 2/3]: C++20 P0482R6 and C2X N2653: Implement mbrtoc8, c8rtomb, char8_t In-Reply-To: <40868945-29d9-3099-fb11-260796a2a022@honermann.net> Message-ID: References: <40868945-29d9-3099-fb11-260796a2a022@honermann.net> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: SVR-IES-MBX-04.mgc.mentorg.com (139.181.222.4) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-Spam-Status: No, score=-3120.8 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2021 18:53:53 -0000 On Sun, 6 Jun 2021, Tom Honermann via Libc-alpha wrote: > This patch provides implementations for the mbrtoc8 and c8rtomb functions > adopted for C++20 via WG21 P0482R6 [1] and proposed for C2X via WG14 N2653 > [2]. It also provides the char8_t typedef from WG14 N2653 [2] and introduces > a _CHAR8_T_SOURCE feature test macro to opt-in to the new declarations. What's the reason for adding _CHAR8_T_SOURCE? We don't normally have feature test macros for such narrow features (_ATFILE_SOURCE is not a good example to follow). Any new feature test macro needs documenting in creature.texi - but I think it would be better not to add a new feature test macro in the first place. _GNU_SOURCE is suitable for a proposed-but-not-yet-adopted (or a feature in a future standard version for which we don't yet have feature test macro support), if in a particular case we get consensus to add the feature without it having been accepted for the standard. > Additionally, in features.h, missing comments for the __GLIBC_USE_ISOC2X, > __GLIBC_USE_DEPRECATED_GETS, and __GLIBC_USE_DEPRECATED_SCANF macros are > added. These are covered by the description of __GLIBC_USE (F). I don't think the __GLIBC_USE_* forms should have their own comments, since the version calling __GLIBC_USE is what should be tested everywhere in the headers. > +/* Copyright (C) 2020 Free Software Foundation, Inc. Copyright dates should include 2021. Each file should have a line before the copyright notice describing its contents. + Contributed by Tom Honermann , 2020. We don't use "Contributed by" any more in glibc. -- Joseph S. Myers joseph@codesourcery.com