From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa4.mentor.iphmx.com (esa4.mentor.iphmx.com [68.232.137.252]) by sourceware.org (Postfix) with ESMTPS id 15170383800A for ; Mon, 7 Jun 2021 19:35:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 15170383800A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com IronPort-SDR: rmRA3ivZ3gX61jrnm5FlPbPpv3w/gPxFoUEqLhrLeE2IFNZWwGZJxjLb0GUMso2/BkmWkztI21 E3WsEULG/7EVxD9HSn03ulGwmPxaKDN4aykSLmGFa7+XwZlu/9wxK+/FObgqXdENWrpVrxdMzM NIUfFKZ29eMqBB5xeMQWlfEg5TfuK/7qQ/t0pcyfPKfG1QoxufreyAuAtvrYc9txMuNp0jb73i x4IGUS3IVrB4sNEo/LUcMs9eWiZCQFvcsPHFENvk1UG/q3cs96EPL9i9AcgQQuS1MbFKPdiH25 A/s= X-IronPort-AV: E=Sophos;i="5.83,255,1616486400"; d="scan'208";a="62258922" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa4.mentor.iphmx.com with ESMTP; 07 Jun 2021 11:35:40 -0800 IronPort-SDR: ahMNSDkm2MxClnzjqUMct+WqfjSvEeEfvqg7syPHgkqisDQovWUkNf9qNpaYopDUGlt2x9m99s 5zKkd+jERvmHz8dk2QfG2GuPQ9WWRs+oxH3AunbDfhT/Am8abVfYHJkiC0MGbT8/CXETVD8PKK fjjDSvXY0Ir5nWGy067BLY/WXro+1wnxkn+8rSuRew1ipRZiUZOaGoxgoi3fsWJ/xocdASbGS/ O3pmhijrpPpMvTNUIZt9eUtYciWtYevE7FXcymJSFsXIMhHP+woP+KZATYxiMlEI0IAEN9sUlg YhI= Date: Mon, 7 Jun 2021 19:35:34 +0000 From: Joseph Myers X-X-Sender: jsm28@digraph.polyomino.org.uk To: Tom Honermann CC: libc-alpha Subject: Re: [PATCH 3/3]: C++20 P0482R6 and C2X N2653: Tests for mbrtoc8, c8rtomb, char8_t In-Reply-To: <895dc28e-d2d6-6c6a-1637-f84184e84190@honermann.net> Message-ID: References: <895dc28e-d2d6-6c6a-1637-f84184e84190@honermann.net> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-Spam-Status: No, score=-3120.8 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2021 19:35:42 -0000 New tests should use support/test-driver.c not the older test-skeleton.c (see support/README-testing.c) and should preferably use the interfaces in support/check.h in place of plain assert. Very few tests should need to define any feature test macros, because they're built with _GNU_SOURCE by default. -- Joseph S. Myers joseph@codesourcery.com