From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa3.mentor.iphmx.com (esa3.mentor.iphmx.com [68.232.137.180]) by sourceware.org (Postfix) with ESMTPS id 869123855004 for ; Mon, 28 Jun 2021 18:33:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 869123855004 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com IronPort-SDR: DdSpkVtBg7nhW1zbhGTtg67q0PlZx78nbGYrdgRSyyK9svcL+r7EtMeF9e1oteeDzINlXUz6YX mVzCHqiAo8ziwu/B4OI+9+XcG5B7PM0PEvvxLFvCYtAbuYUYF8fEPLHYMDPKPFM/fU0IGm9/jF wIRnlkFQ0IYyxmQ/AOUliwGjNTaVtbGLpJbRQ14mRzMD5GKc/GlrwE4zOstHjlUfXy8fL/ccjf PWjJSTI5y5D/BrWpdzICcEs+JyCBrauMXprDwKXpMps6NwU/0i71J9s19ELdnFVowvGLu4jOQD nuw= X-IronPort-AV: E=Sophos;i="5.83,306,1616486400"; d="scan'208";a="62891101" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa3.mentor.iphmx.com with ESMTP; 28 Jun 2021 10:33:09 -0800 IronPort-SDR: Xjq7ZNSGBFrd9k0reEjwLzKnCf6Dmc6mhdPUIQtaAfPWT1B0S2EvgGa9KRUDpiVnX3EspdrMCt kiAo08AOQQKIlnhvGo2JsRuwN8J7Skn49upIS12J69x4XkErYnFyTyrPVLXHOIfhYZIavfuwye TIJwcnT1ZTPPFtXheWGysCkUEPuk7SBZBKEZkxA5yEy5DVckA6Or6STLyma+Nr+pY7WwhY2yE2 Z1cTDXOMzppKhDygRqRhBSmrmZ5BqY2jGSs2fjK/ao+/0BcT2yTb6erhPfdaYk5dLICUOEeGDR ros= Date: Mon, 28 Jun 2021 18:33:03 +0000 From: Joseph Myers X-X-Sender: jsm28@digraph.polyomino.org.uk To: Florian Weimer CC: , =?ISO-8859-15?Q?Alexandra_H=E1jkov=E1?= Subject: Re: [PATCH] Add valgrind smoke test In-Reply-To: <878s2uz91r.fsf@oldenburg.str.redhat.com> Message-ID: References: <20210524121532.1374966-1-ahajkova@redhat.com> <878s2uz91r.fsf@oldenburg.str.redhat.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: SVR-IES-MBX-07.mgc.mentorg.com (139.181.222.7) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-Spam-Status: No, score=-3120.3 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Jun 2021 18:33:12 -0000 On Mon, 28 Jun 2021, Florian Weimer via Libc-alpha wrote: > Would it be okay to run these tests only if $(run-built-tests) is yes, > $(cross-compiling) is no, and configure had found a valgrind binary? We've got rid of the vast bulk of $(cross-compiling) conditionals that actually change what's built, tested or installed; I don't like the idea of adding more, when we already have an example of a test that deals with checking whether a given command (gdb in that case) is available before running it. (And you can't avoid the issue of /usr/bin/true possibly not existing or having the wrong ABI in any case.) -- Joseph S. Myers joseph@codesourcery.com