From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa4.mentor.iphmx.com (esa4.mentor.iphmx.com [68.232.137.252]) by sourceware.org (Postfix) with ESMTPS id 652293847818 for ; Wed, 7 Jul 2021 15:22:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 652293847818 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com IronPort-SDR: DJIe71drNaHX5RSoqLKHiQudDPIEVjEegczQmKg5I5JIr1wlPXvdQ5y+ap18K/EneUW6lZXUCT xWhTVX5yNRA6bDFGXpGzejxe35ybzmXsuuvshdxYB8dqOv5QU60VneWp9bG+Z6E22qfYwJNfZs bG0tckfT5yImO4Vqbyui9/6or6bH0VJY8HkfqVx6c1IekHboCoXYbfZT15QpgdI/pl5V2jbBAz 8YzGeO4PRaPr4QJv4zKlYFOP1WD5w0Mu+0ua3Of/Qv13I02q4YGM1zbzAv5hFuuPqHuQa58Lhe 33U= X-IronPort-AV: E=Sophos;i="5.83,331,1616486400"; d="scan'208";a="63417685" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa4.mentor.iphmx.com with ESMTP; 07 Jul 2021 07:22:54 -0800 IronPort-SDR: bp8OzoAKFsgGLTLesHpIA6C9E2jRA1Axa3fcUs4s186N9KrWBHw7HAa6TWvvt+Je+9iRqzvLUM RmwjETtcaMQX9TbQz2iYwUptsP2+gfRc7VO/VMj/6AsxejCEB7ToVpOsOgxfTaxfkoKdCxteHR A8iNCovXnlwLUItP+N9y6nSvyO+n2sSRYg7kNadCLSyrkSIMJTolakJevcqJ5ef3OWl3SvJTZm a1MLWyH+81tWsAcv6uqZS8cU+A1IJJRfq1q4udfmVYKFqsuVCPh2ujc2/439l7IPbduXgfrFsc A8M= Date: Wed, 7 Jul 2021 15:22:49 +0000 From: Joseph Myers X-X-Sender: jsm28@digraph.polyomino.org.uk To: Florian Weimer CC: Subject: Re: [PATCH] scripts/build-many-glibcs.py: Switch one Arm target to thumb mode In-Reply-To: <87wnq240l7.fsf@oldenburg.str.redhat.com> Message-ID: References: <875yxm6x5j.fsf@oldenburg.str.redhat.com> <87wnq240l7.fsf@oldenburg.str.redhat.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: SVR-IES-MBX-08.mgc.mentorg.com (139.181.222.8) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-Spam-Status: No, score=-3120.1 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Jul 2021 15:22:57 -0000 On Wed, 7 Jul 2021, Florian Weimer via Libc-alpha wrote: > * Joseph Myers: > > > On Wed, 7 Jul 2021, Florian Weimer via Libc-alpha wrote: > > > >> This commit changes arm-linux-gnueabihf-v7a-disable-multi-arch > >> to use thumb mode. The choice is somewhat arbitrary, but there > >> should be at least one thumb mode target. > > > > My inclination would be to add a new variant for this rather than changing > > an existing one. > > Running build-many-glibcs.py isn't free. We can't test all possible > combinations, and -mthumb is a real gap. It also makes sense for the -mthumb variant to have that as the only difference from another variant (rather than the only -mthumb Arm variant also being the only --disable-multi-arch Arm variant). > If we absolutely have to add a new target, should it be based on > arm-linux-gnueabi? Well, it needs to build with at least -march=armv7-a (technically, at least v6t2) - building glibc as Thumb-1 rather than Thumb-2 isn't supported - so that suggests making it like the arm-linux-gnueabihf-v7a variant except for -mthumb added. -- Joseph S. Myers joseph@codesourcery.com